Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bank): reserve proto field numbers used by Penumbra #19298

Closed
wants to merge 1 commit into from
Closed

feat(bank): reserve proto field numbers used by Penumbra #19298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions proto/cosmos/bank/v1beta1/bank.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,14 @@ message Metadata {
//
// Since: cosmos-sdk 0.46
string uri_hash = 8 [(gogoproto.customname) = "URIHash"];

// Used by Penumbra for the Penumbra asset ID.
// Reserved here to ensure cross-system compatibility.
reserved 1984;
reserved "penumbra_asset_id";

// Used by the cosmos asset registry to record images (logos), in json-schema extensions to this message.
// Reserved here to align with Penumbra's upstreaming of those extensions into its proto definitions.
reserved 1985;
reserved "images";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is fine, but i cant guarantee we or some other team may change it in the future

}
Loading