Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store/v2): add the catch up process in the migration #19454
feat(store/v2): add the catch up process in the migration #19454
Changes from 15 commits
927bab0
03cda43
460cedb
ee5bff5
93666bf
8a6c48b
c85bc5a
3db64c2
41a8b5d
4080305
2fbc467
e2389e6
e924387
38a33d9
f589ed0
e82a9ce
a617704
f7ff2c1
654f5a1
09c35e5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this isn't a hot code path it's probably OK, but it'd be better to grow in chunks rather than iterate
cs.Pairs
twice, once to calculate the size and once to marshal.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's what IAVL is doing, I have no benchmarking result but it seems like it is introduced to improve the performance.