chore(server/v2): create v2 subpackage in core #19499

tac0turtle · 2024-02-20T13:33:10Z

Description

Create subpackage for core/appmodule/v2 in cosmossdk.io/core

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

coderabbitai · 2024-02-20T13:33:26Z

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

julienrbrt · 2024-02-20T14:59:34Z

core/appmodule/v2/comet.go

+
+import "context"
+
+// HasPreBlocker is the extension interface that modules should implement to run


This can be then moved in module.go. Additionally we need to update baseapp.

this is a duplicate, baseapp needs the return while the new design uses consensus messages and querying directly from the module

I think in our case, consistency and limiting conflicting apis in better.
Additionally, we cannot have x/upgrade compatible with baseapp and server/v2 if we don't modify in baseapp.
In baseapp, we can update it every pre block instead of checking the returned value.

My point about moving this into core/appmodule/v2/module.go still stand btw

gonna remove this and we go with there is no v2 yet

core/store/database.go

core/appmodule/module.go

x/auth/module.go

core/store/database.go

alexanderbez · 2024-02-25T04:09:28Z

core/store/database.go

+}
+
+// NonConsensusStore is a simple key-value store that is used to store non-consensus data.
+// Note the non-consensus data is not committed to the blockchain and does not allow iteration


We can forbid iteration, although, there is no reason to not support it as it's part of the SS interface and all SS backends support it.

I was thinking to keep the supported api simple ourselves we can avoid it. Do you think its a requirement for users?

Yes, I could see cases where you'd want to iterate over state. E.g. iterate over all WASM contracts or something.

the user would still be able to iterate just not natively

How? What does "not natively" mean?

core/store/database.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

julienrbrt

new appmodule package lgtm, skipped store -- some build errors due to some missed renaming in types/module/module.go

julienrbrt · 2024-02-26T17:02:31Z

core/appmodule/v2/genesis.go

+	"context"
+)
+
+// HasGenesis defines a custom genesis handling API implementation.


What are we going to do about genesis in core v1?
I feel like we should delete if when there is consensus about the api, as we never pushed people to use it.
However, I don't think we agreed on this proposed api yet 👀.

leaving a todo here and we can discuss on the server call

tac0turtle · 2024-02-27T12:13:20Z

going to handle genesis cleanup in a follow up pr

testinginprod added 2 commits February 20, 2024 12:46

add appmodule v2

f5858aa

update

f27418d

tac0turtle added 2 commits February 20, 2024 14:35

v1 preblock is different than v2

ae64a57

fix build

bc067a8

github-actions bot added C:x/auth C:x/upgrade labels Feb 20, 2024

tac0turtle changed the title ~~chore(server/v2): create v2 subpackage in core v2~~ chore(server/v2): create v2 subpackage in core Feb 20, 2024

gas meter

0cd479d

julienrbrt reviewed Feb 20, 2024

View reviewed changes

julienrbrt linked an issue Feb 22, 2024 that may be closed by this pull request

[Feature(core)]: appmodule/v2 #19495

Closed

tac0turtle added 2 commits February 22, 2024 15:34

Merge branch 'server_modular' into tip/serverv2/appmodulev2

fe591e1

Merge branch 'server_modular' into tip/serverv2/appmodulev2

bc56bc6

github-actions bot removed the C:x/upgrade label Feb 22, 2024

tac0turtle added 3 commits February 22, 2024 17:36

Merge branch 'server_modular' into tip/serverv2/appmodulev2

adca043

cleanup

4b2aa9b

add non consensus database

0230dec

tac0turtle commented Feb 23, 2024

View reviewed changes

core/store/database.go Show resolved Hide resolved

tac0turtle marked this pull request as ready for review February 23, 2024 07:52

tac0turtle requested a review from a team as a code owner February 23, 2024 07:52

tac0turtle assigned alexanderbez, julienrbrt and testinginprod Feb 23, 2024

lint fix

3bffa71

julienrbrt reviewed Feb 23, 2024

View reviewed changes

core/appmodule/module.go Outdated Show resolved Hide resolved

julienrbrt reviewed Feb 23, 2024

View reviewed changes

x/auth/module.go Show resolved Hide resolved

use v2 in modules

c98f475

github-actions bot added C:x/staking C:x/gov C:x/distribution distribution module related labels Feb 23, 2024

github-actions bot added C:x/mint C:x/bank C:x/evidence C:x/upgrade C:x/feegrant C:x/nft C:x/consensus C:x/circuit C:x/protocolpool labels Feb 23, 2024

alexanderbez reviewed Feb 25, 2024

View reviewed changes

tac0turtle and others added 2 commits February 25, 2024 15:31

Update core/store/database.go

b8a0b7c

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

Update core/store/database.go

ad1bf8a

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

tac0turtle mentioned this pull request Feb 25, 2024

Outside of AppHash Storage berachain/beacon-kit#294

Closed

tac0turtle added 2 commits February 26, 2024 11:49

Merge branch 'server_modular' into tip/serverv2/appmodulev2

30e2bf6

remove new preblocker

354f841

tac0turtle requested a review from julienrbrt February 26, 2024 10:58

tac0turtle assigned facundomedica Feb 26, 2024

julienrbrt approved these changes Feb 26, 2024

View reviewed changes

add todo

93b4094

tac0turtle merged commit a2b4dea into server_modular Feb 27, 2024
31 of 59 checks passed

tac0turtle deleted the tip/serverv2/appmodulev2 branch February 27, 2024 12:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(server/v2): create v2 subpackage in core #19499

chore(server/v2): create v2 subpackage in core #19499

tac0turtle commented Feb 20, 2024

coderabbitai bot commented Feb 20, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

julienrbrt Feb 20, 2024

tac0turtle Feb 23, 2024

julienrbrt Feb 23, 2024

tac0turtle Feb 26, 2024

alexanderbez Feb 25, 2024

tac0turtle Feb 25, 2024

alexanderbez Feb 26, 2024

tac0turtle Feb 26, 2024

alexanderbez Feb 26, 2024

julienrbrt left a comment

julienrbrt Feb 26, 2024 •

edited

Loading

tac0turtle Feb 26, 2024

tac0turtle commented Feb 27, 2024


		import "context"

		// HasPreBlocker is the extension interface that modules should implement to run

chore(server/v2): create v2 subpackage in core #19499

chore(server/v2): create v2 subpackage in core #19499

Conversation

tac0turtle commented Feb 20, 2024

Description

Author Checklist

Reviewers Checklist

coderabbitai bot commented Feb 20, 2024 • edited Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

julienrbrt left a comment

Choose a reason for hiding this comment

julienrbrt Feb 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tac0turtle commented Feb 27, 2024

coderabbitai bot commented Feb 20, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

julienrbrt Feb 26, 2024 •

edited

Loading