chore: add v0.47.9 and v0.50.4 release notes to main #19531
Conversation
WalkthroughThis update brings a mix of enhancements and fixes to the system. It includes the addition of an in-place testnet CLI command for improved testing capabilities, enhancements in default value population within client contexts, and alignment of math operations with CometBFT standards. Bug fixes address issues with header information in contexts, proposal handler sequences, and CLI logging. A significant change is the introduction of a state-breaking adjustment in the staking module affecting delegations with less than 1 token. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: .coderabbit.yml
Files selected for processing (2)
- CHANGELOG.md (5 hunks)
- x/staking/CHANGELOG.md (2 hunks)
Additional comments: 5
CHANGELOG.md (5)
- 52-57: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-3]
The additions to the changelog under the Improvements section for an unspecified version include links to pull requests for new features or enhancements. It's important to ensure that these entries are placed under the correct version heading and that the descriptions are clear and concise.
- 52-57: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [2-2]
The Bug Fixes section correctly documents various fixes across different components of the SDK. Each entry is linked to its corresponding pull request, providing traceability. It's crucial that these entries are accurate and that the links are valid.
- 52-57: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [3-3]
The entries under the Bug Fixes and API Breaking Changes sections are well-documented, with each fix or change linked to its respective pull request. This section helps users understand the impact of the changes and any necessary actions they may need to take.
- 52-57: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [4-4]
The Deprecated section clearly outlines the features that are being phased out in favor of new implementations. This is crucial for developers to adapt their applications to the latest standards and practices recommended by the SDK.
- 52-57: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [5-5]
The changelog entries for versions v0.50.4 and v0.47.9 include both new features and bug fixes. It's important to ensure that these entries are under the correct version headings and that the descriptions accurately reflect the changes made. The repetition of the
BlockedAddrcheck inCreatePeriodicVestingAccountunder both versions suggests a potential error in documentation or a backport of the feature to an older version. Clarification or correction might be needed here.Verification successful
The verification process has confirmed that the CHANGELOG.md file exists and contains entries for versions v0.50.4 and v0.47.9. Additionally, it has been verified that there are mentions of the
BlockedAddrcheck inCreatePeriodicVestingAccountunder the section related to bug fixes, as well as a mention of adding Amino Msg registration forMsgCreatePeriodicVestingAccount. The repetition of theBlockedAddrcheck under both versions suggests that this change was indeed documented for both versions, which could indicate either a documentation error or a deliberate backport of the feature to an older version. Given this information, it is recommended to clarify or correct the changelog entries as needed to accurately reflect the changes made in each version.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify if the BlockedAddr check was indeed added in both versions or if this is a documentation error. # This script assumes the presence of detailed release notes or PR descriptions for verification. grep -E "BlockedAddr check in CreatePeriodicVestingAccount" CHANGELOG.mdLength of output: 74
Script:
#!/bin/bash # Check if CHANGELOG.md exists and contains entries for versions v0.50.4 and v0.47.9. if [ -f CHANGELOG.md ]; then echo "CHANGELOG.md exists." echo "Searching for versions v0.50.4 and v0.47.9 entries..." grep -E "v0.50.4|v0.47.9" CHANGELOG.md echo "Searching for mentions of 'BlockedAddr' or 'CreatePeriodicVestingAccount'..." grep -E "BlockedAddr|CreatePeriodicVestingAccount" CHANGELOG.md else echo "CHANGELOG.md does not exist." fiLength of output: 1012
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yml
Files selected for processing (2)
- CHANGELOG.md (5 hunks)
- x/staking/CHANGELOG.md (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- CHANGELOG.md
- x/staking/CHANGELOG.md
Merge queue setting changed
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
HeaderInfoin context.DefaultProposalHandler.GetLastValidatorsto accurately handleMaxValidators.Chores