chore: remove sdk imports from server v2 #19744

facundomedica · 2024-03-13T13:05:57Z

Description

Stuff missing/to revisit:

~~Copy pagination.proto to cometbft types, fix proto generation to generate on the correct directory~~
~~Figure out types.Any and cryptotypes.PubKey~~
~~Also genutiltypes.AppGenesisFromFile + sdk version~~

Follow up PR needed: to add the app version info to the GetNodeInfo method

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

coderabbitai · 2024-03-13T13:06:05Z

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

tac0turtle · 2024-03-24T09:25:21Z

gentle ping on this, can we get this wrapped up. i can pick it up if needed

facundomedica · 2024-03-24T12:49:21Z

@tac0turtle whoops, dropped the ball on this one. Will get back to it tomorrow 👌

api/cosmos/base/tendermint/v1beta1/pagination.pulsar.go

tac0turtle · 2024-03-26T20:16:23Z

server/v2/cometbft/client/grpc/cmtservice/pagination.go

+
+// DefaultPage is the default `page` number for queries.
+// If the `page` number is not supplied, `DefaultPage` will be used.
+const DefaultPage = 1


pagination seems like a generic thing, any reason we cant put it into the api pkg at the in server/v2?

Or we put a variation of it in core. This is to avoid sdk imports of pagination in modules. Thoughts?

There's also a proto generated file that contains PageRequest and some other. I think this is also extracted from comet, so if we want to extend this same pagination style everywhere else then we should make it like you said

can we use the api module here?

I think we talked about this on a call, but that would mean we use a pulsar type. ~~Also, those types use codec/any for pubkeys, so we are still going to have a dependency on the sdk~~ EDIT: I'll double-check this last part, I think I got them mixed up

so i think this is fine for now, we should get this merged, but we will need to do another refactor here because we dont want to use the pulsar types. Im not sure where pagination should live to avoid the imports, maybe you can dive into this?

I'm a bit confused, should we not use pulsar on this pr? I started without it but then we talked about using it so I started to use it and added a bunch of utils to make that possible here: use cosmossdk.io/api

we should be able to depend on server v2 here, we can put it in there. the issue is we are adding multiple versions of pagination now, which makes client world harder

…into facu/remove-sdk-deps

server/v2/cometbft/genutil/genesis.go

+	}
+
+	if ag.GenesisTime.IsZero() {
+		ag.GenesisTime = time.Now().Round(0).UTC()


tac0turtle

there is still work to do there.

tac0turtle · 2024-04-17T10:06:59Z

server/v2/cometbft/genutil/genesis.go

@@ -0,0 +1,232 @@
+package genutil


where does this get used?

This is used in getGenDocProvider when creating the node. I put it in a different package to make it easier to remove later if needed

tac0turtle · 2024-04-17T10:08:19Z

server/v2/cometbft/client/grpc/cmtservice/pagination.go

+
+// DefaultPage is the default `page` number for queries.
+// If the `page` number is not supplied, `DefaultPage` will be used.
+const DefaultPage = 1


so i think this is fine for now, we should get this merged, but we will need to do another refactor here because we dont want to use the pulsar types. Im not sure where pagination should live to avoid the imports, maybe you can dive into this?

tac0turtle · 2024-04-17T10:08:37Z

proto/cosmos/base/tendermint/v1beta1/query.proto

-  int64               voting_power      = 3;
-  int64               proposer_priority = 4;
+  string                       address           = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
+  .tendermint.crypto.PublicKey pub_key           = 2 [(gogoproto.nullable) = false];


why this change?

Because google.protobuf.Any will use the sdk's codec package, which is unnecessary here if we use the original types

ah true, dam that type. It was moved now but i guess the code gen needs to be updated

tac0turtle · 2024-04-17T10:09:15Z

proto/cosmos/base/tendermint/v1beta1/query.proto


-option go_package = "github.com/cosmos/cosmos-sdk/client/grpc/cmtservice";
+option go_package = "github.com/cosmos/cosmos-sdk/server/v2/cometbft/client/grpc/cmtservice";


what happens to clients version? part of me thinks this needs to redefined

chore: remove sdk importes from server v2

e136552

facundomedica changed the title ~~chore: remove sdk importes from server v2~~ chore: remove sdk imports from server v2 Mar 13, 2024

facundomedica added 5 commits March 24, 2024 17:45

progress

e70c161

cmtjson

d5567de

add yaml

c81879e

proto

53b6676

proto

0667724

github-advanced-security bot found potential problems Mar 25, 2024

View reviewed changes

facundomedica and others added 2 commits March 26, 2024 11:13

remove more deps

f01c4ef

Merge branch 'server_modular' into facu/remove-sdk-deps

81326f0

facundomedica marked this pull request as ready for review March 26, 2024 20:13

facundomedica requested a review from a team as a code owner March 26, 2024 20:13

tac0turtle reviewed Mar 26, 2024

View reviewed changes

facundomedica added 5 commits April 4, 2024 09:45

merge

5ae0fbb

Merge branch 'server_modular' of https://github.com/cosmos/cosmos-sdk …

6fb6656

…into facu/remove-sdk-deps

use cosmossdk.io/api

8b78f56

fix conflicts

132c52c

fix conflicts + remove version dep on cosmos sdk

611ccbc

github-advanced-security bot found potential problems Apr 15, 2024

View reviewed changes

server/v2/cometbft/genutil/genesis.go

}

if ag.GenesisTime.IsZero() {

ag.GenesisTime = time.Now().Round(0).UTC()

Check warning

Code scanning / CodeQL

Calling the system time Warning

Calling the system time may be a possible source of non-determinism

tac0turtle reviewed Apr 17, 2024

View reviewed changes

tac0turtle closed this May 15, 2024

tac0turtle deleted the facu/remove-sdk-deps branch September 17, 2024 07:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove sdk imports from server v2 #19744

chore: remove sdk imports from server v2 #19744

facundomedica commented Mar 13, 2024 •

edited

Loading

coderabbitai bot commented Mar 13, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

tac0turtle commented Mar 24, 2024

facundomedica commented Mar 24, 2024

tac0turtle Mar 26, 2024

tac0turtle Mar 26, 2024

facundomedica Mar 27, 2024

tac0turtle Mar 30, 2024

facundomedica Apr 4, 2024 •

edited

Loading

tac0turtle Apr 17, 2024

facundomedica Apr 25, 2024

tac0turtle May 2, 2024

tac0turtle left a comment

tac0turtle Apr 17, 2024

facundomedica Apr 17, 2024

tac0turtle Apr 17, 2024

tac0turtle Apr 17, 2024

facundomedica Apr 17, 2024

tac0turtle Apr 17, 2024

tac0turtle Apr 17, 2024


		option go_package = "github.com/cosmos/cosmos-sdk/client/grpc/cmtservice";
		option go_package = "github.com/cosmos/cosmos-sdk/server/v2/cometbft/client/grpc/cmtservice";

chore: remove sdk imports from server v2 #19744

chore: remove sdk imports from server v2 #19744

Conversation

facundomedica commented Mar 13, 2024 • edited Loading

Description

Author Checklist

Reviewers Checklist

coderabbitai bot commented Mar 13, 2024 • edited Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

tac0turtle commented Mar 24, 2024

facundomedica commented Mar 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facundomedica Apr 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tac0turtle left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facundomedica commented Mar 13, 2024 •

edited

Loading

coderabbitai bot commented Mar 13, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

facundomedica Apr 4, 2024 •

edited

Loading