Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): clean-up protos #19858

Merged
merged 1 commit into from
Mar 25, 2024
Merged

chore(api): clean-up protos #19858

merged 1 commit into from
Mar 25, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Mar 25, 2024

Description

Given that #19823 hasn't been merged, we still need to remove the duplicate generate protos that was discovered in that PR.
They are here already: https://github.com/cosmos/cosmos-sdk/tree/main/api/cosmos/accounts/defaults/lockup


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@julienrbrt julienrbrt requested a review from a team as a code owner March 25, 2024 15:39
@julienrbrt julienrbrt changed the title chore: clean-up protos chore(api): clean-up protos Mar 25, 2024
Copy link
Member

@sontrinh16 sontrinh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

@julienrbrt julienrbrt added this pull request to the merge queue Mar 25, 2024
Merged via the queue into main with commit c466887 Mar 25, 2024
60 of 61 checks passed
@julienrbrt julienrbrt deleted the julien/protos branch March 25, 2024 17:16
meetrick pushed a commit to meetrick/cosmos-sdk that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants