Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/staking)!: Add metadata field to validator info #21315

Merged
merged 47 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
455084d
feat(staking/validator): add metadata field to validator detail proto
ziscky Aug 15, 2024
79f694e
feat(staking/validator): protogen
ziscky Aug 15, 2024
65c95fb
feat(staking/validator): update NewDescription to update metadata
ziscky Aug 15, 2024
1a4717d
feat(staking/validator): use the new Description.IsEmpty()
ziscky Aug 15, 2024
3282d5e
feat(staking/validator): update cli to parse metadata
ziscky Aug 15, 2024
83f6327
test(staking/validator): update tests
ziscky Aug 15, 2024
1d4d236
feat(staking/validator): add metadata to create validator sim
ziscky Aug 15, 2024
fbb892f
feat(staking/validator): protogen
ziscky Aug 15, 2024
809a84d
feat(staking/validator): update metadata type to struct
ziscky Aug 22, 2024
6b3de76
feat(staking/validator): update metadata type to struct
ziscky Aug 22, 2024
14eaff9
feat(staking/validator): refactor metadata type
ziscky Aug 22, 2024
a81a3d2
feat(staking/validator): update metadata to object
ziscky Aug 22, 2024
33ca14a
feat(staking/validator): refactor metadata type
ziscky Aug 22, 2024
ca43238
feat(staking/validator): add fn to generate rand uris
ziscky Aug 27, 2024
4337306
feat(staking/validator): update sims
ziscky Aug 27, 2024
e927d50
test(staking/validator): update integration tests
ziscky Aug 27, 2024
fcc82a0
feat(staking/validator): merge main
ziscky Aug 27, 2024
839d578
fix(staking/validator): update metadata flags to accept each metadata…
ziscky Aug 28, 2024
2ebe2a9
test(staking/validator): update tests
ziscky Aug 28, 2024
97b5613
test(staking/validator): update expected gas
ziscky Aug 28, 2024
4d442ed
test(staking/validator): use md generator
ziscky Aug 28, 2024
ba8bc39
feat(staking/validator): update cli arg for profile pic
ziscky Aug 28, 2024
5493969
chore(staking/validator): changelog
ziscky Aug 28, 2024
e403ee3
fix(staking/validator): formatting
ziscky Aug 28, 2024
0befe0c
feat(staking/validator): merge main
ziscky Aug 28, 2024
3df3149
feat(staking/validator): move RandUriOfLength to staking module
ziscky Aug 28, 2024
97e84a9
fix(staking/validator): check DoNotModifyDesc for profile pic uri
ziscky Aug 28, 2024
107cd23
fix(staking/validator): move RandUriOfLength to staking module
ziscky Aug 28, 2024
2478f44
chore(staking/validator): update changelog
ziscky Aug 28, 2024
f77f60b
Merge branch 'main' into ziscky/9988-staking-validator-metadata
ziscky Aug 29, 2024
5e5c817
fix(staking/validator): make rand uri fn more concise
ziscky Aug 30, 2024
4317ac2
test(staking/validator): add test for rand uri fn
ziscky Aug 30, 2024
85d42b0
feat(staking/validator): add social handles field
ziscky Aug 30, 2024
c817001
feat(staking/validator): add IsEmpty() method to Description
ziscky Aug 30, 2024
b742425
feat(staking/validator): add social handles parsing to cli
ziscky Aug 30, 2024
c522e24
test(staking/validator): update sims and tests to include social handles
ziscky Aug 30, 2024
75c9b57
chore(staking/validator): changelog
ziscky Sep 5, 2024
0d3db0a
feat(staking/validator): merge main
ziscky Sep 5, 2024
1ac2085
chore(staking/validator): changelog
ziscky Sep 13, 2024
e651b3c
chore(staking/validator): merge main
ziscky Sep 13, 2024
4631ad1
chore(staking/validator): lint fix
ziscky Sep 21, 2024
a5fc0fe
chore(staking/validator): merge main
ziscky Sep 21, 2024
05bea00
chore(staking/validator): lint fix
ziscky Sep 21, 2024
c894be1
feat(staking/validator): add fn to generate random SocialHandleURIs
ziscky Sep 21, 2024
1862040
feat(staking/validator): add fn to generate random SocialHandleURIs
ziscky Sep 21, 2024
25986ca
chore(staking/validator): lint fix
ziscky Sep 21, 2024
8ac40a0
chore(staking/validator): lint fix
ziscky Sep 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions CHANGELOG.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those should be moved under staking/CHANGELOG.md

Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,35 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i

* (baseapp) [#20291](https://github.com/cosmos/cosmos-sdk/pull/20291) Simulate nested messages.
* (cli) [#21372](https://github.com/cosmos/cosmos-sdk/pull/21372) Add a `bulk-add-genesis-account` genesis command to add many genesis accounts at once.
* (x/staking/types) [#21315](https://github.com/cosmos/cosmos-sdk/pull/21315) Create metadata type and add metadata field in validator details proto
* (x/staking/cli) [#21315](https://github.com/cosmos/cosmos-sdk/pull/21315) Add parsing of `metadata-profile-pic-uri` in `create-validator` JSON.
ziscky marked this conversation as resolved.
Show resolved Hide resolved
* Add cli flag: `metadata-profile-pic-uri` to `edit-validator` cmd.
* (types) [#21315](https://github.com/cosmos/cosmos-sdk/pull/21315) New function `RandURIOfLength` to generate random valid URIs for sims.

### Improvements

* (client) [#21436](https://github.com/cosmos/cosmos-sdk/pull/21436) Use `address.Codec` from client.Context in `tx.Sign`.
* (internal) [#21412](https://github.com/cosmos/cosmos-sdk/pull/21412) Using unsafe.String and unsafe.SliceData.
* (x/staking/types) [#21315](https://github.com/cosmos/cosmos-sdk/pull/21315) Add a `Validate` method to the `Description` type that validates the metadata as well as other description details.


### Bug Fixes

* (baseapp) [#21256](https://github.com/cosmos/cosmos-sdk/pull/21256) Halt height will not commit the block indicated, meaning that if halt-height is set to 10, only blocks until 9 (included) will be committed. This is to go back to the original behavior before a change was introduced in v0.50.0.
* (baseapp) [#21413](https://github.com/cosmos/cosmos-sdk/pull/21413) Fix data race in sdk mempool.

### Client Breaking

* (x/staking/types) [#21315](https://github.com/cosmos/cosmos-sdk/pull/21315) `Description` now has a new field `Metadata`.


### API Breaking Changes

* (baseapp) [#21413](https://github.com/cosmos/cosmos-sdk/pull/21413) Add `SelectBy` method to `Mempool` interface, which is thread-safe to use.
* (types) [#21315](https://github.com/cosmos/cosmos-sdk/pull/21315) New struct `Metadata` to store extra validator information.
* The signature of `NewDescription` has changed to accept an extra argument of type `Metadata`.
* `Description` now has a new field , `Metadata` of type `Metadata`.

ziscky marked this conversation as resolved.
Show resolved Hide resolved

### Deprecated

Expand Down
Loading
Loading