-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server/v2): wire indexer config #22222
Conversation
@julienrbrt your pull request is missing a changelog! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right. You're passing in a specific indexer config rather than the top level indexing config
That's the top level one right: https://github.com/cosmos/cosmos-sdk/pull/22222/files#diff-dacfb6ca404a4cd145bef1af867079a492fd2ee8507a9e724236c8d084dc41d1R27-R31? |
This is the top-level one: cosmos-sdk/schema/indexer/start.go Line 52 in db6a835
See the comments here: cosmos-sdk/schema/indexer/start.go Lines 19 to 22 in db6a835
|
I see, thanks! we need to add toml flags on it too then |
the actual PR is here btw: #22218, i'll do another that targets that branch with the fixes. |
Description
Updates #22218
cc @cool-develope
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...