Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server/v2): wire indexer config #22222

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

julienrbrt
Copy link
Member

Description

Updates #22218

cc @cool-develope


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@github-actions github-actions bot added C:Confix Issues and PR related to Confix C:server/v2 Issues related to server/v2 C:server/v2 cometbft labels Oct 10, 2024
Copy link
Contributor

@julienrbrt your pull request is missing a changelog!

@julienrbrt julienrbrt merged commit b866c06 into indexer/server_v2_init Oct 10, 2024
74 of 75 checks passed
@julienrbrt julienrbrt deleted the julien/config branch October 10, 2024 13:26
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right. You're passing in a specific indexer config rather than the top level indexing config

@julienrbrt
Copy link
Member Author

This doesn't look right. You're passing in a specific indexer config rather than the top level indexing config

That's the top level one right: https://github.com/cosmos/cosmos-sdk/pull/22222/files#diff-dacfb6ca404a4cd145bef1af867079a492fd2ee8507a9e724236c8d084dc41d1R27-R31?

@aaronc
Copy link
Member

aaronc commented Oct 10, 2024

This is the top-level one:

type IndexingConfig struct {

See the comments here:

// Config is the user configuration for all indexing. It should generally be an instance map[string]interface{}
// or json.RawMessage and match the json structure of IndexingConfig, or it can be an instance of IndexingConfig.
// The manager will attempt to convert it to IndexingConfig.
Config interface{}

@julienrbrt
Copy link
Member Author

I see, thanks! we need to add toml flags on it too then

@julienrbrt
Copy link
Member Author

the actual PR is here btw: #22218, i'll do another that targets that branch with the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Confix Issues and PR related to Confix C:server/v2 cometbft C:server/v2 Issues related to server/v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants