feat: Add module accounts service #22312
Conversation
github-actions
bot
added
C:x/staking
C:x/gov
C:x/distribution
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
core/moduleaccounts/service.go
Outdated
| type Service interface { | ||
| Register(string) error | ||
| Address(name string) []byte | ||
| Account(ctx context.Context, name string) (sdk.ModuleAccountI, error) | ||
| AllAccounts() map[string][]byte | ||
|
|
||
| GetModuleAddress(moduleName string) sdk.AccAddress // TODO: @facu tmp, so I don't have to modify a bunch of things in sims right now | ||
| GetAccount(ctx context.Context, addr sdk.AccAddress) sdk.AccountI // TODO: same as above | ||
| } |
There was a problem hiding this comment.
do we need all this? how does ibc use module accounts? do they assume they are created or create them on the fly in the auth module?
There was a problem hiding this comment.
IBC doesn't seem to be using module accounts on anything that is dynamic (like ICAs).
GetModuleAddress(moduleName string) sdk.AccAddress // TODO: @facu tmp, so I don't have to modify a bunch of things in sims right now
GetAccount(ctx context.Context, addr sdk.AccAddress) sdk.AccountI // TODO: same as above
these are just so it's a drop-in replacement in sims, need to be removed once we change sims.
Register(string) error
Address(name string) []byte
AllAccounts() map[string][]byte
These 3 are the ones required
Account(ctx context.Context, name string) (sdk.ModuleAccountI, error)
I'm looking into removing this one, there are a bunch of places in which we do this call just to get the address, or check if the account it registered.
| for name, v := range m.accounts { | ||
| if bytes.Equal(addr, v.addr) { | ||
| return name | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
…/moduleaccounts-svc
…/moduleaccounts-svc
| for k, v := range m.accounts { | ||
| accs[k] = v.addr | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
x/bank/depinject.go
Outdated
| for _, addr := range moduleAccountsService.AllAccounts() { | ||
| addrStr, err := addrCdc.BytesToString(addr) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| blockedAddresses[addrStr] = true | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
…/moduleaccounts-svc
| for name, v := range m.accounts { | ||
| if bytes.Equal(addr, v.addr) { | ||
| return name | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| for k, v := range m.accounts { | ||
| accs[k] = v.addr | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Description
Closes: #XXXX
WIP, want to get comments about the approach before fully committing to it.
Right now calling
Registerin a tx call could lead to unexpected behavior, it's only meant to be called during setup. This can change if we stop keeping any kind of state on module accounts.Accountuses x/auth as the backend for now, to not change the current behavior. This is because we doSetModuleAccount(SetAccount), but I think we could just avoid creating any module accounts, I don't see why we would need it at all.Permissions have been partially removed.
Remaining deps after this PR, which I don't think we can remove as of right now:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...