Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server/v2): init the indexer in server/v2 (partial backport #22218) #22324

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 21, 2024

Description

Closes: #22217


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Introduced a new method for schema decoding, enhancing the application’s ability to handle module data.
    • Added indexing functionality to improve data retrieval and management in the server.
    • Updated configuration settings to include new indexer options.
  • Bug Fixes

    • Removed outdated listener management to streamline consensus operations.
  • Chores

    • Updated dependencies to ensure compatibility and improve overall performance.

This is an automatic backport of pull request #22218 done by [Mergify](https://mergify.com).

Co-authored-by: Julien Robert <[email protected]>
(cherry picked from commit e84c0eb)

# Conflicts:
#	runtime/v2/app.go
#	runtime/v2/go.mod
#	schema/indexer/start.go
#	server/v2/cometbft/go.mod
#	server/v2/cometbft/go.sum
#	server/v2/cometbft/server.go
#	server/v2/config.go
#	server/v2/go.mod
#	server/v2/go.sum
#	server/v2/types.go
#	simapp/v2/go.mod
#	simapp/v2/go.sum
@mergify mergify bot requested a review from a team as a code owner October 21, 2024 14:18
Copy link
Contributor Author

mergify bot commented Oct 21, 2024

Cherry-pick of e84c0eb has failed:

On branch mergify/bp/release/v0.52.x/pr-22218
Your branch is up to date with 'origin/release/v0.52.x'.

You are currently cherry-picking commit e84c0eb86.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   server/v2/cometbft/abci.go
	modified:   server/v2/cometbft/config.go
	modified:   tools/confix/data/v2-app.toml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   runtime/v2/app.go
	deleted by us:   runtime/v2/go.mod
	deleted by us:   schema/indexer/start.go
	both modified:   server/v2/cometbft/go.mod
	both modified:   server/v2/cometbft/go.sum
	both modified:   server/v2/cometbft/server.go
	deleted by us:   server/v2/config.go
	deleted by us:   server/v2/go.mod
	deleted by us:   server/v2/go.sum
	deleted by us:   server/v2/types.go
	both modified:   simapp/v2/go.mod
	both modified:   simapp/v2/go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor

@mergify[bot] your pull request is missing a changelog!

@github-actions github-actions bot added C:Confix Issues and PR related to Confix C:server/v2 Issues related to server/v2 C:schema C:server/v2 cometbft labels Oct 21, 2024
@julienrbrt julienrbrt self-assigned this Oct 21, 2024
@julienrbrt
Copy link
Member

I'll fix the conflicts here.

schema/indexer/start.go Fixed Show fixed Hide fixed
schema/indexer/start.go Fixed Show fixed Hide fixed
@julienrbrt julienrbrt changed the title feat(server/v2): init the indexer in server/v2 (backport #22218) feat(server/v2): init the indexer in server/v2 (partial backport #22218) Oct 21, 2024
@github-actions github-actions bot removed the C:schema label Oct 21, 2024
@julienrbrt julienrbrt merged commit e87562a into release/v0.52.x Oct 21, 2024
68 of 70 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.52.x/pr-22218 branch October 21, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Confix Issues and PR related to Confix C:server/v2 cometbft C:server/v2 Issues related to server/v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants