Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused local variables (backport #22340) #22343

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 23, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Enhanced error logging for key-value store iterator closure.
    • Improved test coverage for cache and mempool functionalities, including new test cases for transaction ordering and cache behavior.
  • Bug Fixes

    • Streamlined logic for handling delegations in the staking keeper.
  • Tests

    • Added multiple new test functions for CacheKVStore and priority nonce mempool.
    • Improved validation logic and concurrency tests for transaction handling.
  • Documentation

    • Updated comments and documentation for clarity in test cases and methods.

This is an automatic backport of pull request #22340 done by [Mergify](https://mergify.com).

(cherry picked from commit 1515856)

# Conflicts:
#	store/cachekv/store_test.go
@mergify mergify bot requested a review from a team as a code owner October 23, 2024 11:22
@mergify mergify bot added the conflicts label Oct 23, 2024
Copy link
Contributor Author

mergify bot commented Oct 23, 2024

Cherry-pick of 1515856 has failed:

On branch mergify/bp/release/v0.52.x/pr-22340
Your branch is up to date with 'origin/release/v0.52.x'.

You are currently cherry-picking commit 151585656.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .golangci.yml
	modified:   simapp/export.go
	modified:   types/mempool/priority_nonce_test.go
	modified:   x/staking/keeper/query_utils.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   store/cachekv/store_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot removed the C:Store label Oct 23, 2024
@julienrbrt julienrbrt merged commit c6b5f4a into release/v0.52.x Oct 23, 2024
9 of 12 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.52.x/pr-22340 branch October 23, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants