Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(indexer): add to modules and implement proto fields #22544
feat(indexer): add to modules and implement proto fields #22544
Changes from 8 commits
24879d0
8047466
5a52970
ce8b931
86fc09a
7e5a665
4ebf63f
38fcf4c
ee06bf2
5381823
748bac9
3cd0277
4b3b800
0a73e70
ebd7397
5196e56
6ed03b5
6c03930
f4a3aa0
5bb37a3
de642e1
668838f
f3cd58f
80d762e
91674b1
228ffb5
e320f48
d94bde6
dc20c04
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead can we just have the
nil
case be handled properly?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, it was already there for keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Invalid Go version and toolchain specification
The specified Go version
1.23.2
and toolchaingo1.23.3
are invalid. The latest stable Go version is 1.22.1 (as of March 2024).Apply this diff to fix the versions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Invalid Go version specified
The specified Go version
1.23.2
and toolchaingo1.23.3
are invalid. The latest stable Go version is 1.22.1 (as of March 2024). Please update to a valid Go version.📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Update google.golang.org/protobuf to address security vulnerability
The codebase extensively uses
protojson.Unmarshal
across multiple packages, making it susceptible to the reported moderate severity vulnerability (infinite loop when unmarshaling certain forms of invalid JSON). Since this is a security concern and the function is used in critical paths including transaction processing and ORM operations, an update is recommended.google.golang.org/protobuf
to at least version v1.33.0 ingo.mod
🔗 Analysis chain
Verify protobuf version compatibility
The PR adds protobuf-related dependencies which align with the implementation of proto fields. However, let's verify if we're using the latest stable version of
google.golang.org/protobuf
.Also applies to: 14-14
Update google.golang.org/protobuf to v1.33.0 or later
The current version v1.35.2 is vulnerable to a moderate severity issue (infinite loop in protojson.Unmarshal) that was patched in v1.33.0. While v1.35.2 is actually the latest version available, it still contains this vulnerability according to the GitHub Security Advisory database. This suggests there might be a discrepancy in the version information, and it would be prudent to verify this further.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 974
Script:
Length of output: 1499