Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go workspace for path management #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use Go workspace for path management #13

wants to merge 1 commit into from

Conversation

LaurentGoderre
Copy link

@LaurentGoderre LaurentGoderre commented Mar 25, 2024 •
edited
Loading

This structure is creating some weird SBOMs. By using the following go.work file, the package naming is preserved

go 1.22.1

use (
    ./cbft
    ./cbftx
    ./cbgt
    ./goproj/src/github.com/couchbase/cbauth
    ./goproj/src/github.com/couchbase/go_json
    ./goproj/src/github.com/couchbase/go-couchbase
    ./goproj/src/github.com/couchbase/gomemcached
    ./goproj/src/github.com/couchbase/goutils
    ./goproj/src/github.com/couchbase/regulator
    ./hebrew
)

https://go.dev/doc/tutorial/workspaces

abhinavdangeti added a commit to abhinavdangeti/cbft that referenced this pull request Apr 8, 2024
@abhinavdangeti
MB-60400: Upgrade bleve@unstable, zapx/v16, go-faiss
1649b76 
* 381a839b Abhi Dangeti | MB-60400: Upgrade to zapx/[email protected] (#1972)
    * c27bdd0 Rahul Rampure | MB-60400: Reduce Garbage generated (#208)
        * 0b5d67d Rahul Rampure | MB-60400: Reduce Garbage (couchbase#13)
* d78f43e9 Rahul Rampure | MB-60400: Reduce garbage generated (#1970)

Change-Id: I9eb31d0ad0ab5682327dc846accb42c18f7faa8c
Reviewed-on: https://review.couchbase.org/c/cbft/+/204688
Well-Formed: Restriction Checker
Well-Formed: Build Bot <[email protected]>
Reviewed-by: Abhi Dangeti <[email protected]>
Tested-by: Abhi Dangeti <[email protected]>
@LaurentGoderre
Copy link
Author

@abhinavdangeti could I get a review for this?

@abhinavdangeti
Copy link
Member

@LaurentGoderre couchbase/cbft is meant to work within the couchbase eco system, this code is necessary for our builds to work and maintainance. If this is something you want to drop - I would recommend forking this project and making the changes you wish.

@LaurentGoderre
Copy link
Author

@abhinavdangeti The snippet I have include in the description using Go workspaces is the recommended way to do this specific thing the project is doing. It gives the same benefits while generating proper dependency metadata in the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LaurentGoderre @abhinavdangeti