-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview build POC (step 1: local) #794
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What can I say? This is great!
I can get a local build for one module up and running in a few seconds, as opposed to half an hour!
How does this work?
It figures out url, branch, start_path from the current directory, Happy to talk through it if you want to know the gory details 👍 |
Streamline the step for aliasing `preview` to your docsSite location (assuming docs team standard MacOS)
"remote" build intended to be used on Github runner, based on payload passed in via Github Actions
I just want you to know that this is exactly what the Gradle Antora plugin and Antora Maven plugin were designed to do, without having to mess with JavaScript. See https://docs.antora.org/gradle-plugin/latest/playbook-provider/ and https://docs.antora.org/maven-plugin/latest/playbook-provider/ The playbook file is managed centrally in any repository you want. It then sets up a playbook to build just the content branch. Even if you don't end up using Maven or Gradle, you might be able to draw ideas from the design of the playbook provider capability in the plugins. NOTE: We envision adding this capability to the |
Thanks @mojavelinux ! At the very least, it sense-checks the requirement 👍 |
* committing preview + local override playbooks * added simple `scripts/preview` wrapper script to do launching
to match how git does it rather than inventing a new convention
Step 1: a command
preview
to build locallypreview
see e.g. https://github.com/couchbaselabs/docs-columnar/blob/preview-build/antora.yml#L12-L21
SCREENCAST: https://drive.google.com/file/d/1ec4WXk77TYtQcJFjJDWMydf2gyhXLs9p/view?usp=sharing
NB: you'll want to add something like
alias preview='node ~/couchbase/docs-site/scripts/preview/preview.js'
to your .zshrc (correct the path for your case)Roadmap:
Step 2: build remotely when branch is pushed
Step 3: niceties for VSCode etc.?