Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix datetime queries with non us locales #372

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Fix datetime queries with non us locales #372

merged 2 commits into from
Oct 18, 2023

Conversation

mdegroux
Copy link
Contributor

description in issue #371

@brantburnett
Copy link
Collaborator

@mdegroux Thanks for the find and the fix. I did one tweak to the PR to avoid allocating an intermediate string on the heap in .NET 6. Check it out and make sure you think it's still okay and we'll get it merged.

Thanks again.

@mdegroux
Copy link
Contributor Author

Didn't knew this trick
If your are confident with, it's ok

@brantburnett brantburnett merged commit cc9830b into couchbaselabs:master Oct 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brantburnett brantburnett brantburnett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdegroux @brantburnett