-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Muons SF update #197
Muons SF update #197
Conversation
Thanks a lot! I think we are missing tracking SF for muons:
|
oops, I'll add them right away in the meantime, some validation plots are available on ingrid at as a SF non-expert, they look more or less ok... but perhaps we should consider adding the x-coverage on the TProfile:s |
Thanks for the plots, nothing suspicious after a quick look! |
PR updated with tracking SF, along with README and extraction script for the provided rootfile |
Thanks a lot looks good! However, I just noticed here [1] that we use the absolute value of eta for the muon SFs, but tracking ones are specified using non-absolute values... Not sure if it's relevant or not. [1] https://github.com/cp3-llbb/Framework/blob/CMSSW_8_0_6p/src/MuonsProducer.cc#L46 |
checking with Hugues (muon POG) the original files contain:
it just appears that the tracking study is uncorrelated with all that POG work and provides SF with a different binning not sure how to detect either case automatically... do you have suggestions ? |
We should probably at some point extend the format to specify which variable is expected in X or Y, but way beyond the scope of the PR. Looking at the numbers, taking eta or |eta| won't change much anyway... |
ok, adding this to the list of issues / features wanted then I'll update the ref trees |
Thanks, I'll try to do it today. Don't forget to rebase too, your branch seems out of date :) |
delete old stuff new SF and README update removing old muon files, renaming utilities adding new eff file merging utility, original source files as well as final framework files updating producer with new SF files Adding tracking SF
0354f5d
to
3604368
Compare
rebased and squashed, ref trees updated |
Thanks a lot! |
for reference: partly addresses #183 |
This PR features several changes and updates, only about muons:
ScaleFactor
directory have been deleted (aka: ZA-analyzers please take note and sync with the rest of us 😄 )sources/muons
mergeEfficiencyFiles.py
is here to help merging the files from HWW which provides separately files for data and MCconvertEGammaTxtFiles.py
to convert such files into FW format has been renamed (→convertEffTxtFileToSF.py
MuonsProducer.py
Note: the HWW SF are now run-dependent as discussed in #196, but note that the run ranges provided are not in sync with Run2016X data-taking eras (:unamused:)
please review, I'll cross fingers that there is no typo hiding somewhere 😉 I'll update the ref trees for merging only if I receive 👍's....