Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muons SF update #197

Merged
merged 2 commits into from
Sep 27, 2016
Merged

Muons SF update #197

merged 2 commits into from
Sep 27, 2016

Conversation

OlivierBondu
Copy link
Member

This PR features several changes and updates, only about muons:

  • the old trigger SF files hanging in the ScaleFactor directory have been deleted (aka: ZA-analyzers please take note and sync with the rest of us 😄 )
  • the previous Muon SF files and source files have been deleted
  • the new source files from both Muon POG and HWW have been added to sources/muons
  • a new script mergeEfficiencyFiles.py is here to help merging the files from HWW which provides separately files for data and MC
  • the old script convertEGammaTxtFiles.py to convert such files into FW format has been renamed (→ convertEffTxtFileToSF.py
  • all new SF json files have been added to the framework MuonsProducer.py

Note: the HWW SF are now run-dependent as discussed in #196, but note that the run ranges provided are not in sync with Run2016X data-taking eras (:unamused:)

please review, I'll cross fingers that there is no typo hiding somewhere 😉 I'll update the ref trees for merging only if I receive 👍's....

@blinkseb
Copy link
Member

Thanks a lot! I think we are missing tracking SF for muons:

Please also remind to include muon tracking specific SFs covering HIP inefficiencies on mere track reconstruction, as from here (https://twiki.cern.ch/twiki/bin/view/CMS/MuonReferenceEffsRun2#Tracking_efficiency_provided_by)

@OlivierBondu
Copy link
Member Author

oops, I'll add them right away

in the meantime, some validation plots are available on ingrid at /home/fynu/obondu/scratch/Higgs/CMSSW_8_0_19/src/cp3_llbb/CommonTools/scripts

as a SF non-expert, they look more or less ok... but perhaps we should consider adding the x-coverage on the TProfile:s

@blinkseb
Copy link
Member

Thanks for the plots, nothing suspicious after a quick look!

@OlivierBondu
Copy link
Member Author

PR updated with tracking SF, along with README and extraction script for the provided rootfile

@blinkseb
Copy link
Member

Thanks a lot looks good! However, I just noticed here [1] that we use the absolute value of eta for the muon SFs, but tracking ones are specified using non-absolute values... Not sure if it's relevant or not.

[1] https://github.com/cp3-llbb/Framework/blob/CMSSW_8_0_6p/src/MuonsProducer.cc#L46

@OlivierBondu
Copy link
Member Author

checking with Hugues (muon POG) the original files contain:

  • 1D integrated in pt vs eta
  • 1D integrated in eta vs pt
  • 2D pt vs abseta
    and 'usually' the 2D ones are the best, and in this case they are the ones we are taking

it just appears that the tracking study is uncorrelated with all that POG work and provides SF with a different binning

not sure how to detect either case automatically... do you have suggestions ?

@blinkseb
Copy link
Member

We should probably at some point extend the format to specify which variable is expected in X or Y, but way beyond the scope of the PR. Looking at the numbers, taking eta or |eta| won't change much anyway...

@OlivierBondu
Copy link
Member Author

ok, adding this to the list of issues / features wanted then

I'll update the ref trees

@blinkseb
Copy link
Member

Thanks, I'll try to do it today. Don't forget to rebase too, your branch seems out of date :)

delete old stuff

new SF and README update

removing old muon files, renaming utilities

adding new eff file merging utility,
original source files as well as final framework files

updating producer with new SF files

Adding tracking SF
@OlivierBondu
Copy link
Member Author

rebased and squashed, ref trees updated

@blinkseb
Copy link
Member

Thanks a lot!

@blinkseb blinkseb merged commit bbe7e50 into cp3-llbb:CMSSW_8_0_6p Sep 27, 2016
@OlivierBondu OlivierBondu deleted the muons_SF branch September 27, 2016 15:22
@OlivierBondu
Copy link
Member Author

for reference: partly addresses #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants