Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add METsignificance #268

Merged

Conversation

alesaggio
Copy link
Contributor

No description provided.

Copy link
Member

@OlivierBondu OlivierBondu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So IIUC the whole MET corrections are now done in the JetMET tools ? These are already in the CMSSW release we are using, no need to check out anything ?

@OlivierBondu
Copy link
Member

please test

@OlivierBondu
Copy link
Member

As expected the check fails for the met_significance branch, could you update the reference trees ?

-------------------------------------------------------------------------------
Check if trees are equals
-------------------------------------------------------------------------------
/opt/app-root/jenkins/workspace/Framework/CMSSW/CMSSW_8_0_30/src/cp3_llbb/Framework/bin/testFrameworkOutput.cc:103
...............................................................................

/opt/app-root/jenkins/workspace/Framework/CMSSW/CMSSW_8_0_30/src/cp3_llbb/Framework/bin/testFrameworkOutput.cc:98: FAILED:
  CHECK( same_hash )
with expansion:
  false
with message:
  [Event 0] Checking branches met_significance of type 

/opt/app-root/jenkins/workspace/Framework/CMSSW/CMSSW_8_0_30/src/cp3_llbb/Framework/bin/testFrameworkOutput.cc:186: FAILED:
  REQUIRE( all_branches_identical )
with expansion:
  false

===============================================================================
test cases:    1 |    0 passed | 1 failed
assertions: 2020 | 2018 passed | 2 failed

Output file does not match reference file: status 2
status = 512

---> test Testcp3_llbbFramework had ERRORS

@pieterdavid
Copy link
Member

pieterdavid commented Nov 8, 2017

They are not in the release, but they are in the branch we're already merging for the MET recipe (the tricky part is if @alesaggio and I got the call to the JetMET tools right... but since the MET branch didn't change, we assumed it worked ;-) ). We could also have pulled the relevant parts out of the JetMET tools... in principle there should only be one or a few modules to add, but we tried the simple option first :-)

@alesaggio
Copy link
Contributor Author

Yes @OlivierBondu I'm doing it

@pieterdavid
Copy link
Member

please test

@OlivierBondu OlivierBondu merged commit eae93e9 into cp3-llbb:CMSSW_8_0_6p Nov 8, 2017
@OlivierBondu
Copy link
Member

tracked at #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants