Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deepCSV SFs #270

Merged
merged 3 commits into from
Nov 8, 2017
Merged

Conversation

alesaggio
Copy link
Contributor

Adding Scale Factors for DeepCSV

Copy link
Member

@OlivierBondu OlivierBondu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks !
Let's wait for the other PR to be merged to factorize the changes to the reference trees, but it looks good

@alesaggio
Copy link
Contributor Author

https://github.com/cp3-llbb/Framework/pull/270/files#diff-a1ce3e72a6655012c2f076271533f7c3R104
with this statement we are actually double-counting. Only one algo name (either "pfDeepCSVJetTags:probb" or "pfDeepCSVJetTags:probbb") should be required, since the deepCSV is defined as the sum of the two.

@OlivierBondu
Copy link
Member

OlivierBondu commented Nov 8, 2017

tracked at #257

@alesaggio
Copy link
Contributor Author

I think we are ready to go :)

@OlivierBondu
Copy link
Member

please test

@OlivierBondu
Copy link
Member

Thanks! the tests outputs are as expected (see below), can you update the corresponding reference trees ?

Branches found in reference tree but not in output tree:

Branches found in output tree but not in the reference tree:
  fatjet_sf_deepCSV_heavyjet_loose
  fatjet_sf_deepCSV_heavyjet_medium
  fatjet_sf_deepCSV_heavyjet_tight
  fatjet_sf_deepCSV_lightjet_loose
  fatjet_sf_deepCSV_lightjet_medium
  fatjet_sf_deepCSV_lightjet_tight
  jet_sf_deepCSV_heavyjet_loose
  jet_sf_deepCSV_heavyjet_medium
  jet_sf_deepCSV_heavyjet_tight
  jet_sf_deepCSV_lightjet_loose
  jet_sf_deepCSV_lightjet_medium
  jet_sf_deepCSV_lightjet_tight

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 is a Catch v1.3.3 host application.
Run with -? for options

-------------------------------------------------------------------------------
Check if trees are equals
-------------------------------------------------------------------------------
/opt/app-root/jenkins/workspace/Framework/CMSSW/CMSSW_8_0_30/src/cp3_llbb/Framework/bin/testFrameworkOutput.cc:103
...............................................................................

/opt/app-root/jenkins/workspace/Framework/CMSSW/CMSSW_8_0_30/src/cp3_llbb/Framework/bin/testFrameworkOutput.cc:157: FAILED:
  CHECK( test_tree->GetNbranches() == n_branches )
with expansion:
  219 == 207

===============================================================================
test cases:     1 |     0 passed | 1 failed
assertions: 20146 | 20145 passed | 1 failed

Output file does not match reference file: status 1
status = 256

---> test Testcp3_llbbFramework had ERRORS

@OlivierBondu OlivierBondu merged commit 429dfb9 into cp3-llbb:CMSSW_8_0_6p Nov 8, 2017
@OlivierBondu
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants