[New Output] Support Note Output #311
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
- Coverage 86.85% 86.33% -0.53%
==========================================
Files 14 14
Lines 1651 1661 +10
==========================================
Hits 1434 1434
- Misses 217 227 +10 ☔ View full report in Codecov by Sentry. |
|
@cpisciotta Currently, the tests do not check if the strings are coloured correctly if I am not mistaken. Do you think this should be covered? What do you think about the formatting I chose for this output? |
…erers. Additionally, I had to decrease the magic numbers in ParsingTests.swift.
ikelax
force-pushed
the
issue-208-support-note-output
branch
from
62a9ad6 to
37cb126
Compare
There was a problem hiding this comment.
Hey @ikelax! I appreciate your contribution. Happy to get this merged in, but can you fix the conflicts first? Thanks!
| /// Regular expression captured groups: | ||
| /// $1 = note | ||
| /// $2 = information | ||
| static let regex = Regex(pattern: "^(note:) (.*)") |
There was a problem hiding this comment.
nit: We can change this to `"^note: (.*)$".
No need to capture note, since it's a static keyword.
I think it LGTM! No need to test the colored output. |
Adresses #208.
Changes
Add a capture group for the Note output.
Testing