Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 're2' to 2023.09.01 #713

Closed
wants to merge 1 commit into from
Closed

Conversation

hjmallon
Copy link

  • I've followed this guide
    step by step carefully. [Yes]

@rbsheth
Copy link
Member

rbsheth commented Oct 26, 2023

Can you check on the CI runs?

@hjmallon
Copy link
Author

Useful spot from the CI, re2 has introduced an abseil dependancy. I guess it must be picking one up from my local env automatically. I will close this PR.

@hjmallon hjmallon closed this Oct 26, 2023
@rbsheth
Copy link
Member

rbsheth commented Oct 26, 2023

@hjmallon Thanks for your contributions! Perhaps we can introduce the abseil dependency through Hunter and update re2?

@hjmallon
Copy link
Author

Yeah I guess it would need a fork of re2? Unless there are some cleverer forkless Hunter things possible now?

@NeroBurner
Copy link

Wanted to fork it for you, but there already is one, probably old, but exists already: https://github.com/cpp-pm/re2/

@hjmallon
Copy link
Author

Thanks, to be honest I'm in no great need of new re2 (we only use it inside grpc) so I'm not going to get to this soon.

@hjmallon hjmallon deleted the pr.re2 branch October 26, 2023 18:25
@NeroBurner
Copy link

latest upstream tag now also available as https://github.com/cpp-pm/re2/releases/tag/2023-09-01

if you get around to it. Hunterizing should be easy as the project already creates the re-config.cmake files itself. So only HunterGate and hunter_add_package() should be needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants