New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change internal State structures to be unsynchronized #1183

Merged

JPercival merged 2 commits into master from unsync-collections

Aug 8, 2023

Contributor

JPercival commented Aug 7, 2023

The internal State object for the cql engine is not thread-safe, and not intended to be shared across threads
- For example, the Stack is thread-specific
This PR changes the internal state to be totally unsynchronized since it'll only ever be used by one thread
~5-10% performance boost on the Main suite


          Change internal State structures to be unsyncronized

814cda2

JPercival requested review from brynrhodes, mdnazmulkarim and barhodes

August 7, 2023 17:13

barhodes approved these changes

View reviewed changes


          let npm test pass through 2

f5420db

mdnazmulkarim approved these changes

View reviewed changes

JPercival merged commit 40a1b4f into master

0 of 2 checks passed

JPercival deleted the unsync-collections branch

August 8, 2023 13:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet