Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release bug fixes #1184

Merged
merged 9 commits into from
Aug 16, 2023
Merged

Release bug fixes #1184

merged 9 commits into from
Aug 16, 2023

Conversation

JPercival
Copy link
Contributor

@JPercival JPercival commented Aug 10, 2023 •
edited
Loading

  • Additional tests for:
    • Expression compilation and execution
    • Forward declarations (disabled due to known bug)
    • Engine validating libraries do not have compilation errors
    • List distinguished overloads (disabled due to known bug)
  • Clean up of tests
    • Renabled some tests that were erroneously disabled
  • Separate engine and visitor to facilitate testing
  • Small cleanup of visitor allow use cases outside of engine
  • Add some temporary APIs to the CqlEngine class to facilitate testing
    • Need to revisit this and decide what the API should look like
  • Fixes to exception handling

@JPercival JPercival marked this pull request as ready for review August 16, 2023 15:33
@JPercival JPercival merged commit e8b7349 into master Aug 16, 2023
2 checks passed
@JPercival JPercival deleted the release-bug-fixes branch August 16, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brynrhodes brynrhodes brynrhodes approved these changes

@mdnazmulkarim mdnazmulkarim mdnazmulkarim approved these changes

@barhodes barhodes Awaiting requested review from barhodes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JPercival @brynrhodes @mdnazmulkarim