Add test for default timezone offset of DateTime

[antvaset]

Closes #1420.

This PR adds tests for calling DateTime(y, m, d, h, m, s, ms) without specifying the timezone offset. As per the spec, it should default to the timezone offset of the evaluation request.

Note that when engine.expression(...) or engine.evaluate(...) is called without passing in the evaluation date time explicitly, it is set to ZonedDateTime.now().

[github-actions]

Formatting check succeeded!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.39%. Comparing base (a7c1636) to head (fa3ef71).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #1423   +/-   ##
=========================================
  Coverage     64.38%   64.39%           
+ Complexity     1921     1920    -1     
=========================================
  Files           494      494           
  Lines         28020    28020           
  Branches       5559     5559           
=========================================
+ Hits          18042    18044    +2     
  Misses         7737     7737           
+ Partials       2241     2239    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brynrhodes]

This is only the test, but doesn't the DateTimeEvaluator need to be updated as well?

[JPercival]

I walked through the code with Anton. The code looks correct to me. I think I was wrong before, the DateTimeEvaluator is using the timezone of the evaluation request.

[brynrhodes]

Hmm.... I walked through this the other day and it wasn't, just did again and I don't see how it is using the evaluation request timestamp:

https://github.com/cqframework/clinical_quality_language/blob/master/Src/java/engine/src/main/java/org/opencds/cqf/cql/engine/elm/executing/DateTimeEvaluator.java#L33

[JPercival]

The only place that's used is here:
https://github.com/cqframework/clinical_quality_language/blob/master/Src/java/engine/src/main/java/org/opencds/cqf/cql/engine/execution/EvaluationVisitor.java#L785-L786

Either the ELM has the offset embedded, or the current offset from the State object is used. That state is set up as part of the evaluation.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[brynrhodes]

I see, I was assuming the evaluator tree was still controlling the visit, but I see that it's the visitor now.