Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved generic instantiation behavior and added type precedence to … #1428

Merged
merged 8 commits into from
Nov 5, 2024

Conversation

brynrhodes
Copy link
Member

…ambiguous resolution logic

Copy link

github-actions bot commented Oct 29, 2024

Formatting check succeeded!

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 78.43137% with 33 lines in your changes missing coverage. Please review.

Project coverage is 64.37%. Comparing base (35668e9) to head (4866823).

Files with missing lines Patch % Lines
...va/org/cqframework/cql/cql2elm/LibraryBuilder.java 42.85% 14 Missing and 2 partials ⚠️
...g/cqframework/cql/cql2elm/model/ConversionMap.java 80.00% 3 Missing and 1 partial ⚠️
...g/cqframework/cql/cql2elm/model/OperatorEntry.java 93.84% 0 Missing and 4 partials ⚠️
...va/org/cqframework/cql/cql2elm/Cql2ElmVisitor.java 80.00% 1 Missing and 1 partial ⚠️
.../src/main/java/org/hl7/cql/model/IntervalType.java 0.00% 2 Missing ⚠️
...odel/src/main/java/org/hl7/cql/model/ListType.java 0.00% 2 Missing ⚠️
...del/src/main/java/org/hl7/cql/model/TupleType.java 0.00% 2 Missing ⚠️
...amework/cql/cql2elm/model/InstantiationResult.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1428      +/-   ##
============================================
- Coverage     64.40%   64.37%   -0.03%     
+ Complexity     1921     1920       -1     
============================================
  Files           494      494              
  Lines         28020    28126     +106     
  Branches       5559     5584      +25     
============================================
+ Hits          18045    18107      +62     
- Misses         7736     7767      +31     
- Partials       2239     2252      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brynrhodes brynrhodes marked this pull request as ready for review October 30, 2024 05:00
@antvaset
Copy link
Contributor

Proposing to add this to this for completeness #1431

Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
74.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@JPercival JPercival merged commit 8390d7a into master Nov 5, 2024
4 of 5 checks passed
@JPercival JPercival deleted the br-generics-2 branch November 5, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants