-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use passed in executionDateTime timeZoneOffset when available #313
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #313 +/- ##
=======================================
Coverage 86.15% 86.15%
=======================================
Files 52 52
Lines 4506 4508 +2
Branches 1270 1270
=======================================
+ Hits 3882 3884 +2
Misses 324 324
Partials 300 300
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, @elsaperelli. It looks really good! I only made a couple of very minor comments -- none of which affect the actual code (just code comments and a test description).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thanks for making the engine better!
Pull requests into cql-execution require the following.
Submitter and reviewer should ✔ when done.
For items that are not-applicable, mark "N/A" and ✔.
CDS Connect and Bonnie are the main users of this repository.
It is strongly recommended to include a person from each of those projects as a reviewer.
Summary
Previously,
getDateTime()
indateTime.ts
was not passing in atimeZoneOffset
when creating a newDateTime
. We only want to do this if anexecutionDateTime
is not provided since it will set thetimeZoneOffset
to thetimeZoneOffset
of the evaluation. In the case where theexecutionDateTime
is passed in, we want thetimeZoneOffset
to come from that. We now achieve this by passing thectx.getExecutionDateTime().timeZoneOffset
to functions that callgetDateTime()
.Submitter:
npm run test:plus
to run tests, lint, and prettier)cql4browsers.js
built withnpm run build:browserify
if source changed.Reviewer:
Name: