-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Implies Operator and update to cql2elm 3.12.0 #320
Conversation
…on localids. manual work around for bad choicetype elm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a drive-by review. I did not look at it closely (sorry), but I wanted to make one suggestion. Given that you had to hand edit some of the generated JSON for tests to pass, it might be helpful to put a comment in the source code near the tests that it affects. I can picture myself updating the translator in the future, re-running the build:test-data
command, getting broken tests, and being confused as to why they're breaking (because, of course, I will forget that you needed to hand-edit the JSON). So a little comment might help forgetful people like me to remember: If this test breaks, check the generated JSON for a repeated type
element.
BTW -- nice job figuring out the mysteries of the translator 2.x to 3.x changes so you could get the test generator working again. That's not fun. Thanks for taking it on!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great stuff, @hossenlopp. Thank you!
I've left some comments about the tests that expect the context localId entries to be populated. My comments suggest fixing something that doesn't cause problems, but is technically incorrect (and was there previously, so not your fault) -- and an idea about how we can keep test maintenance easier in the future.
Since this was a previously existing issue, and you did not introduce any regression, I'm not "requesting changes", because it's valid for you to tell me it's out of scope for this PR and should be handled as a separate issue. But if you have the time and want to tackle it now rather than later, that's good too.
https://github.com/cqframework/cql-execution/projects/1#card-52575839 move to done after merge |
… localId in the elm structure
…query-test.ts with helperfile usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, @hossenlopp -- and thanks for implementing that test helper for getting local ids. It was probably a little tedious up front, but it will probably save us a lot of tediousness going forward!
I left one comment for something to consider, but honestly, it's totally optional -- this is really good as it is. So... I'm approving. Thanks again for this great work!
…o make test checks simpler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Thank you, @hossenlopp!
Implements the
implies
operator and updates CQL translator to 3.12.0. Also updates gradle wrapper to latest 8.x for Java 21 support. Enables the spec-tests for Implies operator.Note: The translator has a bug with choice types in the output that caused issues with some tests. This issue was manually edited out in the ELM after running the
build:test-data
command. cqframework/clinical_quality_language#1380Pull requests into cql-execution require the following.
Submitter and reviewer should ✔ when done.
For items that are not-applicable, mark "N/A" and ✔.
CDS Connect and Bonnie are the main users of this repository.
It is strongly recommended to include a person from each of those projects as a reviewer.
Submitter:
npm run test:plus
to run tests, lint, and prettier)cql4browsers.js
built withnpm run build:browserify
if source changed.Reviewer:
Name: