Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when using NinePatch with Texture2DRegion. #945

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Dwergi
Copy link
Contributor

@Dwergi Dwergi commented Sep 2, 2024

Resolves #943

Copy link
Collaborator

@AristurtleDev AristurtleDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dwergi. I don’t particularly like forcing the user to know that each of the edges must be the same, even if it’s shown in the documentation comments.

This might be something that needs to be reworked from the original code in the future.

@AristurtleDev AristurtleDev merged commit aed3d14 into craftworkgames:develop Sep 23, 2024
1 check passed
@Dwergi Dwergi deleted the fix/ninepatch-padding branch September 25, 2024 07:06
AristurtleDev added a commit that referenced this pull request Sep 30, 2024
* fix(Matrix3x2): decompose method (#941)

* Fix bug when using `NinePatch` with `Texture2DRegion`. (#945)

Resolves #943

* BitmapFont now always loads from TitleContainer. (#946)

Fixes KNI web builds when using BitmapFont (#944)

* Fix bug when creating a NinePatch using the Texture2DRegion extension method (#948)

* Revert UV code (#951)

* [Weekly] Version 4.0.3 (#952)

* Starting 4.0.2 release prep

* Update changelog

* Bump version number to 4.0.3

* Updated workflows to use dotnet 8

---------

Co-authored-by: Ilia Bahrebar <[email protected]>
Co-authored-by: Dwergi <[email protected]>
Co-authored-by: Joseph Newman <[email protected]>
Co-authored-by: Jeremy Swartwood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NinePatch does not work correctly with arbitrary Texture2DRegion patches
2 participants