Deprecate Treasure.Utils.Argument (#125)

The library isn't necessary in .NET 8+.
craigktreasure · Nov 17, 2024 · a2eedbe · a2eedbe
1 parent e8b7c3d
commit a2eedbe
Show file tree

Hide file tree

Showing 11 changed files with 44 additions and 237 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -21,11 +21,11 @@ jobs:
       # don't check format on CI builds due to common breaking changes in the .NET SDK
       checkFormat: false
 
-  release_ci:
-    name: Release Treasure.Utils to NuGet.org
-    needs: build_ci
-    if: ${{ contains(github.event.head_commit.message, 'do release') }}
-    uses: ./.github/workflows/workflow_release.yml
-    secrets: inherit
-    with:
-      package-version: ${{ needs.build_ci.outputs.package_version }}
+  # release_ci:
+  #   name: Release Treasure.Utils to NuGet.org
+  #   needs: build_ci
+  #   if: ${{ contains(github.event.head_commit.message, 'do release') }}
+  #   uses: ./.github/workflows/workflow_release.yml
+  #   secrets: inherit
+  #   with:
+  #     package-version: ${{ needs.build_ci.outputs.package_version }}
diff --git a/.github/workflows/workflow_build.yml b/.github/workflows/workflow_build.yml
@@ -38,36 +38,36 @@ jobs:
         id: version
         uses: ./.github/actions/version-vars
 
-      - name: Restore
-        run: dotnet restore
+      # - name: Restore
+      #   run: dotnet restore
 
-      - name: Format validation
-        if: ${{ inputs.checkFormat }}
-        run: dotnet format --no-restore --verify-no-changes
+      # - name: Format validation
+      #   if: ${{ inputs.checkFormat }}
+      #   run: dotnet format --no-restore --verify-no-changes
 
-      - name: Build
-        run: dotnet build --configuration Release --no-restore
+      # - name: Build
+      #   run: dotnet build --configuration Release --no-restore
 
-      - name: Test
-        run: dotnet test --configuration Release --no-build --verbosity normal /p:CollectCoverage=true
+      # - name: Test
+      #   run: dotnet test --configuration Release --no-build --verbosity normal /p:CollectCoverage=true
 
-      - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@v5
-        with:
-          name: codecov
-          directory: __test-results
-          token: ${{ secrets.CODECOV_TOKEN }}
-          fail_ci_if_error: true
-          verbose: true
+      # - name: Upload coverage to Codecov
+      #   uses: codecov/codecov-action@v5
+      #   with:
+      #     name: codecov
+      #     directory: __test-results
+      #     token: ${{ secrets.CODECOV_TOKEN }}
+      #     fail_ci_if_error: true
+      #     verbose: true
 
-      - name: Upload output artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: output_${{ inputs.platform }}
-          path: __output
+      # - name: Upload output artifact
+      #   uses: actions/upload-artifact@v4
+      #   with:
+      #     name: output_${{ inputs.platform }}
+      #     path: __output
 
-      - name: Upload package artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: packages_${{ inputs.platform }}
-          path: __packages
+      # - name: Upload package artifact
+      #   uses: actions/upload-artifact@v4
+      #   with:
+      #     name: packages_${{ inputs.platform }}
+      #     path: __packages
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -25,12 +25,7 @@
     <GlobalPackageReference Include="Microsoft.Build.CopyOnWrite" Version="1.0.334" />
   </ItemGroup>
 
-  <ItemGroup>
-    <PackageVersion Include="Nullable"                                          Version="1.3.1" />
-  </ItemGroup>
-
   <ItemGroup Label="Test Only Packages" Condition=" '$(TestOnlyPackagesEnabled)' == 'true' ">
-    <PackageVersion Include="BenchmarkDotNet"                                   Version="0.14.0" />
     <PackageVersion Include="coverlet.collector"                                Version="6.0.2" />
     <PackageVersion Include="coverlet.msbuild"                                  Version="6.0.2" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk"                            Version="17.11.1" />

diff --git a/README.md b/README.md
@@ -7,6 +7,10 @@ This repository contains some of my common utilities.
 
 ## Treasure.Utils.Argument
 
+> **Important**
+>
+> This package is now deprecated as it isn't necessary in .NET 8+.
+
 [![NuGet](https://img.shields.io/nuget/v/Treasure.Utils.Argument)](https://www.nuget.org/packages/Treasure.Utils.Argument/)
 [![NuGet](https://img.shields.io/nuget/dt/Treasure.Utils.Argument)](https://www.nuget.org/packages/Treasure.Utils.Argument/)
 

diff --git a/Treasure.Utils.sln b/Treasure.Utils.sln
@@ -3,12 +3,6 @@ Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio Version 17
 VisualStudioVersion = 17.2.32526.322
 MinimumVisualStudioVersion = 10.0.40219.1
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Treasure.Utils.Argument", "src\Treasure.Utils.Argument\Treasure.Utils.Argument.csproj", "{5F893AFE-E9C3-47AF-A872-95D1A9CD75FC}"
-EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Tests", "Tests", "{B012001D-4B86-460D-A3E1-FC3EEC840D13}"
-EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Treasure.Utils.Argument.Tests", "test\Treasure.Utils.Argument.Tests\Treasure.Utils.Argument.Tests.csproj", "{EF141707-718F-49EC-99B9-8D7B59CBCCEF}"
-EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{A18B8F8E-8296-4968-A569-16F3F4FE045E}"
 	ProjectSection(SolutionItems) = preProject
 		.editorconfig = .editorconfig
@@ -40,20 +34,11 @@ Global
 		Release|Any CPU = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(ProjectConfigurationPlatforms) = postSolution
-		{5F893AFE-E9C3-47AF-A872-95D1A9CD75FC}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
-		{5F893AFE-E9C3-47AF-A872-95D1A9CD75FC}.Debug|Any CPU.Build.0 = Debug|Any CPU
-		{5F893AFE-E9C3-47AF-A872-95D1A9CD75FC}.Release|Any CPU.ActiveCfg = Release|Any CPU
-		{5F893AFE-E9C3-47AF-A872-95D1A9CD75FC}.Release|Any CPU.Build.0 = Release|Any CPU
-		{EF141707-718F-49EC-99B9-8D7B59CBCCEF}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
-		{EF141707-718F-49EC-99B9-8D7B59CBCCEF}.Debug|Any CPU.Build.0 = Debug|Any CPU
-		{EF141707-718F-49EC-99B9-8D7B59CBCCEF}.Release|Any CPU.ActiveCfg = Release|Any CPU
-		{EF141707-718F-49EC-99B9-8D7B59CBCCEF}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
 	EndGlobalSection
 	GlobalSection(NestedProjects) = preSolution
-		{EF141707-718F-49EC-99B9-8D7B59CBCCEF} = {B012001D-4B86-460D-A3E1-FC3EEC840D13}
 		{7C628D75-6B6A-4D42-A4D9-45C6ACA51FB5} = {A18B8F8E-8296-4968-A569-16F3F4FE045E}
 		{61D20241-7C98-4A60-AA8D-C7614B7D6768} = {A18B8F8E-8296-4968-A569-16F3F4FE045E}
 	EndGlobalSection

diff --git a/src/Treasure.Utils.Argument/CallerArgumentExpressionAttribute.cs b/src/Treasure.Utils.Argument/CallerArgumentExpressionAttribute.cs
diff --git a/src/Treasure.Utils.Argument/README.md b/src/Treasure.Utils.Argument/README.md
@@ -1,5 +1,10 @@
 # Treasure.Utils.Argument
 
+> **Important**
+>
+> This package is now deprecated as it isn't necessary in .NET 8+.
+> The source code remains here for reference if necessary.
+
 [![NuGet](https://img.shields.io/nuget/v/Treasure.Utils.Argument)](https://www.nuget.org/packages/Treasure.Utils.Argument/)
 [![NuGet](https://img.shields.io/nuget/dt/Treasure.Utils.Argument)](https://www.nuget.org/packages/Treasure.Utils.Argument/)
 

diff --git a/src/Treasure.Utils.Argument/Treasure.Utils.Argument.csproj b/src/Treasure.Utils.Argument/Treasure.Utils.Argument.csproj
diff --git a/test/Directory.Build.props b/test/Directory.Build.props
@@ -17,12 +17,6 @@
     <CoverletOutputFormat>cobertura</CoverletOutputFormat>
   </PropertyGroup>
 
-  <PropertyGroup Condition="$([MSBuild]::IsOSPlatform('Windows'))">
-    <!-- Setup TFM properties for testing .NET Standard TFM's on supported platforms. -->
-    <PlatformTFMSuffix Condition="$([MSBuild]::IsOSPlatform('Windows'))">-windows</PlatformTFMSuffix>
-    <DefaultNetStandardTestTFM >net8.0$(PlatformTFMSuffix)</DefaultNetStandardTestTFM>
-  </PropertyGroup>
-
   <ItemGroup>
     <!-- Exclude test projects from code coverate reports. -->
     <AssemblyAttribute Include="System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverageAttribute" />

diff --git a/test/Treasure.Utils.Argument.Tests/ArgumentTests.cs b/test/Treasure.Utils.Argument.Tests/ArgumentTests.cs
diff --git a/test/Treasure.Utils.Argument.Tests/Treasure.Utils.Argument.Tests.csproj b/test/Treasure.Utils.Argument.Tests/Treasure.Utils.Argument.Tests.csproj