Skip to content

Commit

Permalink
Fix benchmark build errors (#82)
Browse files Browse the repository at this point in the history
The benchmark project itself builds just fine. However, when you attempt
to run the benchmarks, the BenchmarkDotNet generated code fails to
adhere to my `.editorconfig` settings and then it throws errors. After
more time than I care to admit fighting with it, I have landed on
disabling the offending rule for `*.notcs` files.

```
[*.notcs] # BenchmarkDotNet generated files

# CS1591: Missing XML comment for publicly visible type or member
dotnet_diagnostic.CS1591.severity = none
```
  • Loading branch information
craigktreasure authored Nov 17, 2023
1 parent 2379fbb commit fc72d42
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -229,3 +229,8 @@ csharp_style_unused_value_expression_statement_preference = discard_variable

# IDE0059: Remove unnecessary value assignment
csharp_style_unused_value_assignment_preference = discard_variable

[*.notcs] # BenchmarkDotNet generated files

# CS1591: Missing XML comment for publicly visible type or member
dotnet_diagnostic.CS1591.severity = none

0 comments on commit fc72d42

Please sign in to comment.