Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Directory.Packages.props #108

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

craigktreasure
Copy link
Owner

@craigktreasure craigktreasure commented Jun 11, 2024

This change consolidates all package version definitions to the root Directory.Packages.props.

Summary by CodeRabbit

  • New Features

    • Introduced global package references to enhance source linking and versioning.
    • Enabled source-only packages for better dependency management.
    • Added configurations to support test-only packages in projects.
  • Chores

    • Updated test project settings to prevent them from being publishable by default.

This change consolidates all package version definitions to the root `Directory.Packages.props`.
Copy link

coderabbitai bot commented Jun 11, 2024

Warning

Review failed

The pull request is closed.

Walkthrough

Walkthrough

The recent changes introduce global package references for essential tools and libraries, including Microsoft.SourceLink.GitHub and Nerdbank.GitVersioning, along with several test-only packages like BenchmarkDotNet and xunit. Additionally, new configuration files (Directory.Build.props) have been added to streamline the build and test processes, ensuring that test projects are not publishable by default and enabling the use of source-only packages.

Changes

File Path Change Summary
Directory.Packages.props Added global package references for Microsoft.SourceLink.GitHub, Nerdbank.GitVersioning, and test-only packages.
src/Directory.Build.props Introduced logic to enable source-only packages and included an import statement for another Directory.Build.props file.
test/Directory.Build.props Configured test projects to enable test-only packages and set them to not be publishable by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@craigktreasure craigktreasure enabled auto-merge (squash) June 11, 2024 18:03
@craigktreasure craigktreasure merged commit 6bbd765 into main Jun 11, 2024
3 checks passed
@craigktreasure craigktreasure deleted the craig/consolidate-packages-props branch June 11, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant