Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch global.json to 7.0.100 for macOS #31

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

craigktreasure
Copy link
Owner

  • dotnet format is broken on macOS with .NET SDK 7.0.101 (see Dotnet format cannot find MSBuild on SDK 7.0.101 dotnet/format#1785). So, we're installing 7.0.100 in addition to the latest and patching the global.json file at build time on macOS to prevent rolling forward to the latest SDK version. This means we'll use the latest on Windows and Linux, but macOS will be pinned o 7.0.100 for now until it's fixed.

  - `dotnet format` is broken on macOS with .NET SDK 7.0.101 (see dotnet/format#1785). So, we're installing 7.0.100 in addition to the latest and patching the `global.json` file at build time on macOS to prevent rolling forward to the latest SDK version. This means we'll use the latest on Windows and Linux, but macOS will be pinned o 7.0.100 for now until it's fixed.
@craigktreasure craigktreasure enabled auto-merge (squash) December 21, 2022 16:29
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #31 (2232bcc) into main (d127cc7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           14        14           
=========================================
  Hits            14        14           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@craigktreasure craigktreasure merged commit 7efb226 into main Dec 21, 2022
@craigktreasure craigktreasure deleted the craig/patch-globaljson branch December 21, 2022 16:31
craigktreasure added a commit to craigktreasure/CentralBuildOutput that referenced this pull request Dec 21, 2022
  - `dotnet format` is broken on macOS with .NET SDK 7.0.101 (mimicking craigktreasure/Treasure.Utils#31). So, we're installing 7.0.100 in addition to the latest and patching the `global.json` file at build time on macOS to prevent rolling forward to the latest SDK version. This means we'll use the latest on Windows and Linux, but macOS will be pinned o 7.0.100 for now until it's fixed.
craigktreasure added a commit to craigktreasure/CentralBuildOutput that referenced this pull request Dec 21, 2022
- `dotnet format` is broken on macOS with .NET SDK 7.0.101 (mimicking craigktreasure/Treasure.Utils#31). So, we're installing 7.0.100 in addition to the latest and patching the `global.json` file at build time on macOS to prevent rolling forward to the latest SDK version. This means we'll use the latest on Windows and Linux, but macOS will be pinned o 7.0.100 for now until it's fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant