Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analyzers #63

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Fix analyzers #63

merged 1 commit into from
Sep 23, 2023

Conversation

craigktreasure
Copy link
Owner

I'm trying a few changes to see if I can get the analyzers to behave properly locally. For some reason, they get into a state where they ignore the rules defined in the .editorconfig files entirely. Something similar to this, but it certainly isn't "fixed". Also, I believe there is a case where the node reuse makes this even worse requiring me to kill all dotnet processes in order for some settings changes to even take effect, so I'm attempting the use of the Directory.Build.rsp file with the /NodeReuse:false setting to see if it helps at all. I have a feeling that there is a quirk between the nodes that VS starts up and the ones that the CLI starts up.

I'm trying a few changes to see if I can get the analyzers to behave properly locally. For some reason, they get into a state where they ignore the rules defined in the `.editorconfig` files entirely. Something similar to [this](dotnet/roslyn-analyzers#6281), but it certainly isn't "fixed". Also, I believe there is a case where the node reuse makes this even worse requiring me to kill all `dotnet` processes in order for some settings changes to even take effect, so I'm attempting the use of the `Directory.Build.rsp` file with the `/NodeReuse:false` setting to see if it helps at all. I have a feeling that there is a quirk between the nodes that VS starts up and the ones that the CLI starts up.
@craigktreasure craigktreasure enabled auto-merge (squash) September 23, 2023 19:20
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #63 (2b5c988) into main (eb8feed) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           14        14           
=========================================
  Hits            14        14           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@craigktreasure craigktreasure merged commit 361dd17 into main Sep 23, 2023
5 checks passed
@craigktreasure craigktreasure deleted the craig/fix-analyzers branch September 23, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant