API Metrics Feature #775
Open
API Metrics Feature #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have the feeling this PR will not be accepted as it is, because you are already proposing other changes unrelated to the prometheus metrics. Th fastest way to have this feature merged is probably go easy on @crazy-max and provide him with a clean MR easy to review. |
jooola
suggested changes
Feb 15, 2023
Comment on lines
+6
to
+12
| apimetrics: | ||
| enableApi: true | ||
| enableScan: true | ||
| token: ApiToken | ||
| port: 6080 | ||
| apiPath: /v1/metrics | ||
| scanPath: /v1/scan |
There was a problem hiding this comment.
Keys have inconsistent casing. It should probably be snake case ?
| Notif *model.Notif `yaml:"notif,omitempty" json:"notif,omitempty"` | ||
| RegOpts model.RegOpts `yaml:"regopts,omitempty" json:"regopts,omitempty" validate:"unique=Name,dive"` | ||
| Providers *model.Providers `yaml:"providers,omitempty" json:"providers,omitempty"` | ||
| APIMetrics *model.APIMetrics `yaml:"apimetrics,omitempty" json:"metricsapi,omitempty"` |
There was a problem hiding this comment.
The yaml and json key are different.
I personally think the naming is not the best, maybe "metrics" alone in better ?
Comment on lines
+11
to
+36
| // New is a factory function creating a new Handler instance | ||
| func New(scanFn func()) *Handler { | ||
| return &Handler{ | ||
| fn: scanFn, | ||
| Path: "/v1/scan", | ||
| } | ||
| } | ||
|
|
||
| // Handler is an API handler used for triggering container update scans | ||
| type Handler struct { | ||
| fn func() | ||
| Path string | ||
| } | ||
|
|
||
| // Handle is the actual http.Handle function doing all the heavy lifting | ||
| func (handle *Handler) Handle(w http.ResponseWriter, r *http.Request) { | ||
| log.Info().Msg("Updates triggered by HTTP API request.") | ||
|
|
||
| _, err := io.Copy(os.Stdout, r.Body) | ||
| if err != nil { | ||
| log.Error().Err(err).Msg("Error") | ||
| return | ||
| } | ||
|
|
||
| handle.fn() | ||
| } |
There was a problem hiding this comment.
What is this used for in the context of the prometheus metrics ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature api end points for pulling metrics and triggering a new scan.
Added feature to pull docker images