Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] HTML print layout looks bad #281

Closed
TimidRobot opened this issue Apr 22, 2022 · 22 comments
Closed

[Bug] HTML print layout looks bad #281

TimidRobot opened this issue Apr 22, 2022 · 22 comments
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work

Comments

@TimidRobot
Copy link
Member

TimidRobot commented Apr 22, 2022

Description

HTML print layout looks bad

We expect people may print all of the legal tools Deeds and Legal Codes pages. The following list pages provide links to the legal tools:

Reproduction

  1. Ex. legal-tools-dev.creativecommons.org/licenses/by/4.0/deed.en

Expectation

  • Icons should be consistent size
  • Text should flow without overlap
  • Digital navigation elements should be hidden

Screenshots

Screen Shot 2022-04-22 at 08 24 39

Screen Shot 2022-04-22 at 08 24 47

Screen Shot 2022-04-22 at 08 25 08

Environment

  • Device: Laptop
  • OS: macOS Monterey 12.3.1
  • Browser: Firefox 99.0.1
@TimidRobot TimidRobot added 🟧 priority: high Stalls work on the project or its dependents 🏁 status: ready for work Ready for work 🛠 goal: fix Bug fix 📄 aspect: text Concerns the textual material in the repository 💻 aspect: code Concerns the software code in the repository labels Apr 22, 2022
@AMMAR-62
Copy link

AMMAR-62 commented Jul 5, 2022

Anyone on this issue yet?? ... may I work on this??

@TimidRobot
Copy link
Member Author

Anyone on this issue yet?? ... may I work on this??

@AMMAR-62 no one else is working on this yet. Please keep the print media CSS in its own file and keep it as simple as possible.

@MdSahil-oss
Copy link

MdSahil-oss commented Sep 4, 2022

@TimidRobot I'm new to creativecommons, I think this issue has been resolved because when I visit to the page https://legal-tools-dev.creativecommons.org/licenses/by/4.0/deed.en I don't see any kind of icons/text overlapping using browser chrome/firefox on my laptop (window 11 OS) but I see text/icon on the page doesn't render very well (looks very bad) on the screen size (width) 500px (or smaller)

Screenshots

Screenshot (6)

Screenshot (8)

Do we need to fix this ?

@TimidRobot
Copy link
Member Author

@MdSahil-oss

[...] I think this issue has been resolved because when I visit to the page https://legal-tools-dev.creativecommons.org/licenses/by/4.0/deed.en I don't see any kind of icons/text overlapping using browser chrome/firefox on my laptop (window 11 OS) [...]

The issue is only visible from print dialog/output.

[...] I see text/icon on the page doesn't render very well (looks very bad) on the screen size (width) 500px (or smaller)
[...]
Do we need to fix this ?

Sure! Help documenting the responsiveness issue(s) in an issue would also be welcomed.

@TimidRobot TimidRobot added the help wanted Open to participation from the community label Sep 16, 2022
@Akbar-Ibrahim

This comment was marked as outdated.

@kevinRapahel

This comment was marked as outdated.

@adetyaz

This comment was marked as outdated.

@tolubishops0

This comment was marked as outdated.

@TimidRobot

This comment was marked as outdated.

@Tapo41

This comment was marked as outdated.

@TimidRobot TimidRobot added 🟨 priority: medium Not blocking but should be fixed soon and removed 🟧 priority: high Stalls work on the project or its dependents labels Mar 6, 2023
@TimidRobot

This comment was marked as outdated.

@shreyansh1910
Copy link

shreyansh1910 commented Mar 31, 2023

@TimidRobot As i see this problem still persist .
i would like to work on it.
I need few information does this issue only persist in this page or some other page also.
Do you want me to create new css for printing or make correction to already present css .
(please guide me I am little new)

@TimidRobot
Copy link
Member Author

@TimidRobot As i see this problem still persist . i would like to work on it. I need few information does this issue only persist in this page or some other page also. Do you want me to create new css for printing or make correction to already present css . (please guide me I am little new)

Please see Contribution Guidelines — Creative Commons Open Source.

I think a new CSS file.

@vanamaabhi2004

This comment was marked as outdated.

@BalrajDhakad
Copy link

Hey,
This is Balraj,
I want to work on this issue could you please assign it to me.
@TimidRobot

@TimidRobot
Copy link
Member Author

Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs (we generally don't assign issues prior to resolution).

@BalrajDhakad
Copy link

I have read it but able to get what you want to say about assigning this issue to me
@TimidRobot

@SamarthShukla17
Copy link

Hi @TimidRobot
Is this https://legal-tools-dev.creativecommons.org/licenses/by/4.0/deed.en the page you want to be addressed in the issue?

@TimidRobot
Copy link
Member Author

@SamarthShukla17 That page is an example of a Deed. We want to improve printing of all of the tools Deed and Legal Code pages (I also updated the issue description).

@SamarthShukla17
Copy link

Thankyou @TimidRobot for the clarification.

@TimidRobot
Copy link
Member Author

@nobodys-ghost please make a comment on this issue so GitHub will allow me to assign it to you

@nobodys-ghost
Copy link
Contributor

I've added a pull request to fix this issue. (see #484 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 📄 aspect: text Concerns the textual material in the repository 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work
Projects
Status: Done
Development

No branches or pull requests