Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed site navigation from licenses/ and publicdomain/ on print #484

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

nobodys-ghost
Copy link
Contributor

@nobodys-ghost nobodys-ghost commented Oct 17, 2024

Fixes

Description

This pull request hides the site and in-page navigation from pages in licenses/ and publicdomain/ when printed. I've tested my changes in Firefox, Chrome, Opera, and Microsoft Edge.

Also see related Data pull request (PR):

Technical details

I added a media query to hide the sitewide header and footer elements when printed to base.css.

Tests

To verify:

  1. Compile the static site
  2. Navigate to http://127.0.0.1:8006/licenses/list.en and go to any of the legal code or deed pages
  3. Open the print dialog
  4. Confirm the site wide header and footer, as well as the in page navigation (if originally present) are gone.

Screenshots

Before

Site Header
image
Site Footer
image
In page navigation
image

After

No site header
image
No site footer
image
No side navigation
image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@nobodys-ghost nobodys-ghost requested review from a team as code owners October 17, 2024 19:09
@nobodys-ghost nobodys-ghost requested review from TimidRobot and Shafiya-Heena and removed request for a team October 17, 2024 19:09
@TimidRobot TimidRobot self-assigned this Oct 31, 2024
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely an improvement, thank you!

@TimidRobot TimidRobot merged commit 7d58d63 into creativecommons:main Nov 5, 2024
3 checks passed
@nobodys-ghost nobodys-ghost deleted the print-cleanup branch November 5, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants