-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARIA attribute added to website for accessibility #336
base: main
Are you sure you want to change the base?
Conversation
Looks good to me, |
Thank you @Murdock9803 |
docs/_includes/header.html
Outdated
|
||
<nav class="ancilliary-menu"> | ||
<nav class="ancilliary-menu" role="navigation" aria-label="Main menu"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This label is incorrect, it should bw Ancillary Menu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a current open issue on this, pr has been created to address this issue from vocabulary repo.
Hi @SisiVero There's a lot of work here and after starting to review it I believe there's a distinction worth putting here. Work here would need to be on items held within the content area of the cc-resource-archive pages. The global header and global footer, if they could do with improvements related to ARIA, that is work that should be documented as an Issue on the main Vocabulary repository, and then done via PRs there. We don't want the header/footer forking from upstream here. |
Okay, @possumbilities , I think there is an open issue on that currently, I'll verify. |
@SisiVero If you believe its not covered there, please feel free to. |
Hi @possumbilities , i've removed the aria attributes from the footer and header. do review and get back to me, thank you. |
Fixes
Description
This PR addresses the issue of adding ARIA to the website to enhance accessibility.
Tests
ARIA were added to the necessary files accordingly.
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin