Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improve Color Contrast for Headings Using Style Guide Colors #838

Merged

Conversation

SumaiyaaRq
Copy link
Contributor

@SumaiyaaRq SumaiyaaRq commented Oct 25, 2024

Fixes

Pending Resolution:

  • Low contrast between text and background: Poor contrast makes text hard to read, particularly for visually impaired users.

Description

This PR enhances the color contrast for headings to improve readability and align with accessibility best practices by using color from the color palette in CC Style Guide (2019). While the palette includes other colors with higher contrast, I selected this particular color because it offers a good balance between readability and visual appeal, ensuring consistency with the design aesthetic.

Technical details

Selected Color: Orange(#fb7729)
Previous Color: Gold (#efbe00)

Tests

  1. Open the homepage of the project.
  2. Check the heading.
  3. See changes

Screenshots

Before:
Screenshot 2024-10-25 at 7 35 43 PM

After:
Screenshot 2024-10-25 at 7 34 56 PM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@SumaiyaaRq SumaiyaaRq requested review from a team as code owners October 25, 2024 14:06
@SumaiyaaRq SumaiyaaRq requested review from TimidRobot, possumbilities and Dhruvi16 and removed request for a team October 25, 2024 14:06
@TimidRobot TimidRobot self-assigned this Oct 30, 2024
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@TimidRobot TimidRobot merged commit bb6809a into creativecommons:main Oct 30, 2024
1 check passed
@SumaiyaaRq
Copy link
Contributor Author

@TimidRobot Thank you so much for reviewing and approving it !

@SumaiyaaRq SumaiyaaRq deleted the feature/Improve-heading-contrast branch November 7, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Accessibility] Accessibility Issues Identified on the Website
2 participants