Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the data_analysis.py to improve performance & readability of code.Fixed spelling mistake in README.md #69

Merged
merged 10 commits into from
Mar 7, 2024

Conversation

siddheshhr
Copy link
Contributor

@siddheshhr siddheshhr commented Mar 3, 2024

Refactored code using list comprehensions for improved readability and potential performance gains (data_analysis.py, lines 95-105).Also fixed a spelling mistake in README.md

Fixes

Optimizes the code performance and make the code more readable

Description

Reduced memory usage: The changes in the code avoids creating and discarding temporary tokens lists for each tag. Instead, it directly creates a list comprehension with the lowercase words, minimizing memory churn.
Conciseness and readability: The use of list comprehension in the updated code leads to a more concise and arguably more readable code. It expresses the step of splitting, lowercasing, and appending in one line, improving code clarity.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

…d potential performance gains (data_analysis.py, lines 95-105)
@siddheshhr siddheshhr requested review from a team as code owners March 3, 2024 14:25
@siddheshhr siddheshhr requested review from Shafiya-Heena and possumbilities and removed request for a team March 3, 2024 14:25
@TimidRobot

This comment was marked as outdated.

analyze/data_analysis.py Outdated Show resolved Hide resolved
Removed the extra space as said before line 98
analyze/data_analysis.py Outdated Show resolved Hide resolved
@siddheshhr siddheshhr changed the title Updated the data_analysis.py to improve performance & readability of code Updated the data_analysis.py to improve performance & readability of code.Fixed spelling mistake in README.md Mar 5, 2024
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! thank you!

@TimidRobot TimidRobot merged commit 7c58cec into creativecommons:main Mar 7, 2024
1 check failed
@siddheshhr
Copy link
Contributor Author

siddheshhr commented Mar 7, 2024

good work! thank you!

Thankyou! enjoyed contributing to this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants