-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the data_analysis.py to improve performance & readability of code.Fixed spelling mistake in README.md #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d potential performance gains (data_analysis.py, lines 95-105)
siddheshhr
requested review from
Shafiya-Heena and
possumbilities
and removed request for
a team
March 3, 2024 14:25
This comment was marked as outdated.
This comment was marked as outdated.
TimidRobot
requested changes
Mar 4, 2024
Removed the extra space as said before line 98
TimidRobot
requested changes
Mar 4, 2024
siddheshhr
changed the title
Updated the data_analysis.py to improve performance & readability of code
Updated the data_analysis.py to improve performance & readability of code.Fixed spelling mistake in README.md
Mar 5, 2024
TimidRobot
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work! thank you!
Thankyou! enjoyed contributing to this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored code using list comprehensions for improved readability and potential performance gains (data_analysis.py, lines 95-105).Also fixed a spelling mistake in README.md
Fixes
Optimizes the code performance and make the code more readable
Description
Reduced memory usage: The changes in the code avoids creating and discarding temporary tokens lists for each tag. Instead, it directly creates a list comprehension with the lowercase words, minimizing memory churn.
Conciseness and readability: The use of list comprehension in the updated code leads to a more concise and arguably more readable code. It expresses the step of splitting, lowercasing, and appending in one line, improving code clarity.
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin