Hover effect added to Explore button #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mobile screen as it is empty, hence no need for it in this page
SisiVero
requested review from
TimidRobot and
Shafiya-Heena
and removed request for
a team
✅ Deploy Preview for cc-search-portal ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi, and thank you for doing this work. After further review the Issue in question here as moved to
🚧 status: blocked
Additionally, this PR adds changes that are not related to adding a hover effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Description
This PR addresses the issue of lack of hover effect in the explore and donate buttons.
It also addresses the issue of redundant empty menu button for mobile screens being removed as There is no menu hence there is no need for the button. This issue was mentioned in issue #237 by @SisiVero .
##Technical
I added hover effect to the Explore button at the top of the page, ensuring that the colors align with the colors used in the page.
I added a transition effect to make it aesthetically pleasing when a user hovers on it.
I made sure no extra class names were added and the pattern for calling class name was followed.
I also ensured that the hover effect class contents is placed below the already existing class contents for easy access.
I removed the button tag with "expand-menu" class because it is meant for mobile screens and currently there are no menus to expand therefore there is no use for it.
Checklist
Update index.md).mainormaster).visible errors.