Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update staging logic to accept any string that starts with "stage" #116

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

TimidRobot
Copy link
Member

Description

There are a few spots where there is logic based on whether a staging environment is being configured. This PR updates the logic to test the beginning of the string (.startswith("stage")) instead of the entire string ( == "stage").

Technical details

I don't think this is a satisfactory solution to Add support for multiple instances in a role · Issue #3, but it will allow forward movement until I architect a comprehensive solution.

Tests

I ran SaltStack highstate against all hosts before and after changes to verify that the results are the same (no changes).

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@TimidRobot TimidRobot requested a review from a team as a code owner October 8, 2020 17:04
@TimidRobot TimidRobot self-assigned this Oct 8, 2020
@TimidRobot TimidRobot requested review from kgodey, mathemancer and zackkrida and removed request for a team, mathemancer and kgodey October 8, 2020 17:04
@TimidRobot TimidRobot merged commit 7c0ed29 into master Oct 8, 2020
@TimidRobot TimidRobot deleted the startswith-stage branch October 8, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants