-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pure kotlin dependency-free Marshaller/Unmarshaller and native #15
base: master
Are you sure you want to change the base?
Conversation
That's a pretty significant level of effort, thanks. Notes:
|
|
Thanks for the response. I have to admit I don't have the immediate time to incorporate this but hopefully I can revisit it soon. |
If you want I can do the changes you requested and update this PR |
This provides native variants for all the components. Code is adapted from java protobuf code.
I added some flexibility and changed it to use JS/JVM tools on those platforms. By looking through protobufjs it looks like it implements same things as kotlin-pure code and doesn't get advantage of any js functions. So it feels like protobufjs doesn't provide any value. Should we make js and native both use kotlin pure? |
Writing this to show my support for this feature! 🙌 |
@LiewJunTung and @phcoder - Sorry I haven't done more here, I haven't been using Kotlin as much lately in my day job. In general I would take this and make a set of "pure" projects to not disturb the existing projects. Can't make any promises when I can revisit though, sorry. |
Originally based on cretz/pb-and-k#15. Fixes This is a rebase of #29 onto the latest version of master.
Originally based on cretz/pb-and-k#15. Fixes This is a rebase of #29 onto the latest version of master.
Originally based on cretz/pb-and-k#15. This is a rebase of #29 onto the latest version of master. Fixes #19.
This provides native variants for all the components.
Code is adapted from java protobuf code.