[CRT-32] Add assertions to scratch #50
Conversation
There was a problem hiding this comment.
This PR seems (relatively) further away from being mergeable, the code has a few rough edges. You might also want to fix the CI 😄
A UI question: do the blocks disappear from the toolbox when we've run out of them, or do we display them as unavailable / 0 blocks left? We might want to clarify the desired behaviour. I can see pros/cons from a pedagogical perspective.
| async pressGreenFlag() { | ||
| return this.page | ||
| .getByTestId("stage-controls") | ||
| .locator("img:first-child") |
There was a problem hiding this comment.
I assume no other IDs are available? 😢
There was a problem hiding this comment.
no, unfortunately not. we would need to copy over the "Controls" component to add testids. we could do that but I think I would rather go with this for now to avoid having too much scratch code copied over?
| AppIFrameMessage, | ||
| AppIFrameRequest, | ||
| AppIFrameResponse, | ||
| } from "../../../../frontend/src/types/app-iframe-message"; |
There was a problem hiding this comment.
I see we now have a lot of relative paths with 3 or more levels of ../. It's not super obvious where we're importing from anymore, and since we're clearly leaving the scope of the current path, wouldn't it be clearer at that point to switch to absolute paths?
There was a problem hiding this comment.
oops, that was automatically done by the IDE but you are right ^^
There was a problem hiding this comment.
The problem is that we need a alias because this comes from a different project ^^ So maybe just change this once we have our external library for the iframe communication?
No description provided.