[CRT-5] Added Classes API #52
Conversation
pierluca
force-pushed
the
feature/CRT-5_api_class
branch
from
2bfa095
to
1016f30
Compare
| @ApiQuery({ name: "teacherId", required: false, type: Number }) | ||
| @ApiOkResponse({ type: ExistingClassTeacherDto, isArray: true }) | ||
| async findAll( | ||
| @Query("teacherId", new ParseIntPipe({ optional: true })) | ||
| teacherId?: number, | ||
| ): Promise<ExistingClassTeacherDto[]> { |
There was a problem hiding this comment.
Hmm it would be nice if we did not have to add these decorators twice. according to the docs, @query should suffice? (https://docs.nestjs.com/openapi/types-and-parameters)
was there something wrong with that?
There was a problem hiding this comment.
I had issues originally, but I resolved them recently - I can revisit.
There was a problem hiding this comment.
Just checked: without the ApiQuery decorator, it shows up as required.
| create(klass: Prisma.ClassUncheckedCreateInput): Promise<Class> { | ||
| const checkedClass: Prisma.ClassCreateInput = { | ||
| name: klass.name, |
There was a problem hiding this comment.
what is the difference between the checked/unchecked types here?
There was a problem hiding this comment.
checked: { ..., teacher: { connect: { id: XXX } } }, it verifies that the ID is valid and the row exists.
unchecked: { ..., teacherId: XXX }, inserts as-is in database and lets the thing crash if a constraint is violated.
There was a problem hiding this comment.
so in both cases there will be an exception but once by the db and once by prisma?
| // TODO: Implement this properly when auth is available | ||
| // TODO: Only allow teachers to see their own classes |
There was a problem hiding this comment.
and once we do that, do we still include the teacher in the response?
There was a problem hiding this comment.
I'd say so. Generic endpoint, same handling on the frontend, just an authz limitation.
No description provided.