Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Support IBC MsgUpgradeClient #287

Conversation

cdc-Hitesh
Copy link
Contributor

Fixes #284

@cdc-Hitesh cdc-Hitesh changed the title Problem: Support IBC 'MsgUpgradeClient` Problem: Support IBC MsgUpgradeClient Jun 22, 2021
@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #287 (50b0e72) into tx-revamp-dev (b96ed43) will increase coverage by 7.63%.
The diff coverage is 98.34%.

Impacted file tree graph

@@                Coverage Diff                @@
##           tx-revamp-dev     #287      +/-   ##
=================================================
+ Coverage          89.34%   96.98%   +7.63%     
=================================================
  Files                101      134      +33     
  Lines               3613     5764    +2151     
  Branches             261      374     +113     
=================================================
+ Hits                3228     5590    +2362     
+ Misses               385      174     -211     
Impacted Files Coverage Δ
lib/src/client/client.ts 80.95% <ø> (ø)
lib/src/transaction/msg/bank/msgsend.spec.ts 100.00% <ø> (ø)
lib/src/transaction/msg/bank/msgsend.ts 100.00% <ø> (ø)
lib/src/transaction/msg/gov/ow.types.ts 94.73% <ø> (ø)
.../src/transaction/msg/staking/MsgBeginRedelegate.ts 91.89% <ø> (ø)
.../src/transaction/msg/staking/MsgCreateValidator.ts 94.23% <ø> (ø)
lib/src/utils/txDecoder.spec.ts 100.00% <ø> (ø)
...action/msg/gov/proposal/SoftwareUpgradeProposal.ts 87.87% <75.00%> (+37.87%) ⬆️
.../msg/gov/proposal/CancelSoftwareUpgradeProposal.ts 95.00% <80.00%> (+41.66%) ⬆️
lib/src/transaction/signable.ts 93.88% <81.81%> (-0.53%) ⬇️
... and 112 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da8cc2f...50b0e72. Read the comment docs.

@cdc-Hitesh cdc-Hitesh changed the base branch from dev to tx-revamp-dev July 8, 2021 05:26
@crypto-eddy
Copy link
Contributor

@cdc-Hitesh CI is failing on this PR

@cdc-Hitesh
Copy link
Contributor Author

@eddycpc I have fixed the CI issues along with others.

@crypto-eddy crypto-eddy merged commit 30d24ff into crypto-org-chain:tx-revamp-dev Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: Support IBC core message types
2 participants