Apply suggestions from code review

crypto-org-chain · Sep 27, 2023 · bffefdf · bffefdf
1 parent b169866
commit bffefdf
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 23 deletions.
diff --git a/integration_tests/contracts/contracts/TestICA.sol b/integration_tests/contracts/contracts/TestICA.sol
@@ -103,6 +103,7 @@ contract TestICA {
     }
 
     function onPacketResultCallback(uint64 seq, bytes calldata ack) external payable returns (bool) {
+        // To prevent called by arbitrary user
         // require(msg.sender == module_address);
         lastAckSeq = seq;
         lastAck = ack;

diff --git a/x/cronos/events/bindings/cosmos/precompile/ica/i_ica_module.abigen.go b/x/cronos/events/bindings/cosmos/precompile/ica/i_ica_module.abigen.go
diff --git a/x/cronos/events/bindings/src/ICA.sol b/x/cronos/events/bindings/src/ICA.sol
@@ -6,5 +6,4 @@ interface IICAModule {
     function registerAccount(string calldata connectionID, string calldata version) external payable returns (bool);
     function queryAccount(string calldata connectionID, address addr) external view returns (string memory);
     function submitMsgs(string calldata connectionID, bytes calldata data, uint256 timeout) external payable returns (uint64);
-    function onPacketResult(uint64 seq, address packetSenderAddress, bytes calldata ack) external payable returns (bool);
 }