Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: flake devShell is not valid #1172

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 19, 2023

Solution:

  • remove gomod2nix

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- remove gomod2nix
@yihuang yihuang requested a review from a team as a code owner September 19, 2023 02:44
@yihuang yihuang requested review from JayT106, leejw51crypto and mmsqe and removed request for a team September 19, 2023 02:44
@yihuang yihuang enabled auto-merge September 19, 2023 02:47
@yihuang yihuang added this pull request to the merge queue Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1172 (8374bea) into main (35d10cf) will decrease coverage by 19.11%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1172       +/-   ##
===========================================
- Coverage   33.95%   14.84%   -19.11%     
===========================================
  Files         113       77       -36     
  Lines       11222     6764     -4458     
===========================================
- Hits         3810     1004     -2806     
+ Misses       7034     5677     -1357     
+ Partials      378       83      -295     

see 54 files with indirect coverage changes

Merged via the queue into crypto-org-chain:main with commit e6adb05 Sep 19, 2023
28 of 29 checks passed
@yihuang yihuang deleted the fix-flake branch September 19, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants