Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a testing crate #68

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Expose a testing crate #68

wants to merge 10 commits into from

Conversation

keks
Copy link
Member

@keks keks commented Aug 22, 2024

The testing crate can be used by provider implementers to run the HPKE test suite using their own provider. We specifically need to to run the tests against the libcrux-backed provider.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have tests implemented twice now. Once in the provide and once on the hpke crate. Shouldn't we skip one of them? This seems to duplicate the code.

hpke-rs-tests/Cargo.toml Outdated Show resolved Hide resolved
@@ -31,6 +31,7 @@ rand_chacha = { version = "0.3", default-features = false }
[dev-dependencies]
criterion = { version = "0.5", features = ["html_reports"] }
rand = { version = "0.8" }
hpke-rs-tests = { path = "../hpke-rs-tests/" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a version right away so we can release it later.

@franziskuskiefer
Copy link
Member

#66 changed the tests a little. This PR needs to get updated for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants