-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose a testing crate #68
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have tests implemented twice now. Once in the provide and once on the hpke crate. Shouldn't we skip one of them? This seems to duplicate the code.
@@ -31,6 +31,7 @@ rand_chacha = { version = "0.3", default-features = false } | |||
[dev-dependencies] | |||
criterion = { version = "0.5", features = ["html_reports"] } | |||
rand = { version = "0.8" } | |||
hpke-rs-tests = { path = "../hpke-rs-tests/" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a version right away so we can release it later.
#66 changed the tests a little. This PR needs to get updated for that. |
The testing crate can be used by provider implementers to run the HPKE test suite using their own provider. We specifically need to to run the tests against the libcrux-backed provider.