Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added correct prefixing for stretch, fill and fill-available values #204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/supported-value.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,28 @@ export default function supportedValue(property, value) {
if (transitionProperties[property]) {
prefixedValue = prefixedValue.replace(transPropsRegExp, prefixTransitionCallback)
} else if (el.style[property] === '') {
const prePrefixedValue = prefixedValue

// Value with a vendor prefix.
prefixedValue = prefix.css + prefixedValue

// Hardcode test to convert "flex" to "-ms-flexbox" for IE10.
if (prefixedValue === '-ms-flex') el.style[property] = '-ms-flexbox'

// Change "strech" and "fill" values to "fill-available" and prefix them correctly
if (
prePrefixedValue === 'stretch' ||
prePrefixedValue === 'fill' ||
prePrefixedValue === 'fill-available'
) {
prefixedValue = 'fill-available'
if (prefix.js === 'Moz') {
prefixedValue = '-moz-available'
} else if (prefix.js !== 'ms' || prefix.browser === 'edge') {
prefixedValue = '-webkit-fill-available'
}
}

// Test prefixed value.
el.style[property] = prefixedValue

Expand Down
32 changes: 32 additions & 0 deletions src/supported-value.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,5 +78,37 @@ describe('css-vendor', () => {
prefix.js === 'ms' && prefix.browser !== 'edge' ? false : value
)
})

it('should return known fill-available value prefixed', () => {
let value = 'fill-available'
if (prefix.js === 'Moz') {
value = '-moz-available'
} else if (prefix.js !== 'ms' || prefix.browser === 'edge') {
value = '-webkit-fill-available'
}
expect(supportedValue('width', 'fill-available')).to.eql(
prefix.js === 'ms' ? false : `${value}`
)
})

it('should return known stretch value prefixed', () => {
let value = 'fill-available'
if (prefix.js === 'Moz') {
value = '-moz-available'
} else if (prefix.js !== 'ms' || prefix.browser === 'edge') {
value = '-webkit-fill-available'
}
expect(supportedValue('width', 'stretch')).to.eql(prefix.js === 'ms' ? false : `${value}`)
})

it('should return known fill value prefixed', () => {
let value = 'fill-available'
if (prefix.js === 'Moz') {
value = '-moz-available'
} else if (prefix.js !== 'ms' || prefix.browser === 'edge') {
value = '-webkit-fill-available'
}
expect(supportedValue('width', 'fill')).to.eql(prefix.js === 'ms' ? false : `${value}`)
})
})
})