Added exporting types from jss #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
reviewed
Jul 18, 2018
packages/jss/src/index.js
Outdated
| Classes, | ||
| Jss, | ||
| StyleSheet | ||
| } |
There was a problem hiding this comment.
Does it work?
export type {} from './types';
There was a problem hiding this comment.
Yes, it works. Good catch 👍
kof
reviewed
Jul 18, 2018
| JssStyle, | ||
| Plugin, | ||
| generateClassName, | ||
| RuleListOptions, |
There was a problem hiding this comment.
Maybe, I don't know. It might be needed at some time especially because we export RuleList.
Also, I would like to export those now and not have to add exports every time later on.
kof
reviewed
Jul 18, 2018
| generateClassName, | ||
| RuleListOptions, | ||
| Rule, | ||
| Renderer, |
There was a problem hiding this comment.
That depends on wether or not we allow people to write there own renderers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#777