-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Docker image tagging #919
base: main
Are you sure you want to change the base?
Conversation
I think that this tag structure would be very useful! However, I'm thinking about how we should name the image with the latest version of existing code. If seen outside of the context of this repo (say in the situation where this was on the Docker hub), Also, |
I think the thought behind having :main as the tag is that it represents what is on the branch main. If we add a dev branch the tag would be called :dev. I do however see your point, and if we rename it to something else my vote would probably be on As for :latest it will be created whenever a Git tag is created. Just forgot to list it but I have edited the description now. |
I think my reasoning is that having an explicit tag for marking the latest revision of the code is good. I would agree that |
After doing some more googling I don't think |
It does look like it is possible to add pre/postfixes to the branch names. So we could do something like |
There is also something called edge which seams to be used by Alpine for example. So :edge would be the latest commit on main. |
Yeah, edge feels pretty good. I also saw that Busybox uses unstable, so that may also work despite the impression it gives. |
I think I like edge over unstable. So from my point of view ether |
I will vote for |
Co-authored-by: Goostaf <[email protected]>
This PR expands the Docker image tags to be more extensive.
As written this workflow will create the following tags in the following scenarios.
On push/merge to main:
:main:edgeOn PR targeting main:
On Git tag:
Before I mark this draft PR as ready to merge I would like some feedback on which of these tags we actually want. For now I have basically included everything but I don't know if we only want some subset of these or if we like this extensive system?